[Terminal Output] bug fixes to text sizer and missed lines rendered issue. #142524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 29, 2022 17:05
…sts added to prevent future regressions
…button state). increased playback speed to make up for removal of multi line per frame rendering
mitodrummer
added
bug
mitodrummer
added
the
release_note:skip
opauloh
reviewed
Oct 3, 2022
| @@ -39,6 +39,8 @@ describe('SessionView component', () => { | |||
| dispatchEvent: jest.fn(), | |||
| })), | |||
| }); | |||
|
|
|||
| global.ResizeObserver = require('resize-observer-polyfill'); | |||
opauloh
reviewed
Oct 3, 2022
| @@ -234,7 +234,7 @@ export const useXtermPlayer = ({ | |||
| // there is some random race condition with the jump to feature that causes these calls to error out. | |||
| } | |||
| } else { | |||
| linesToPrint = lines.slice(lineNumber, lineNumber + TTY_LINES_PER_FRAME); | |||
| linesToPrint = lines.slice(lineNumber, lineNumber + 1); | |||
There was a problem hiding this comment.
yea, it was an optimization in an attempt to limit the amount of state changes. caused more problems than solved..
There was a problem hiding this comment.
Got it!
If rendering shows to be a problem for larger sections, we can think about other solutions, either using Throttle or requestAnimationFrame, then we can make playback faster, but internally we are optimizing when to render.
added 2 commits
October 3, 2022 16:09
…e in multi container sessions on the same pod
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 4, 2022
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]> (cherry picked from commit 6de0091)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2022
…ssue. (#142524) (#142545) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]> (cherry picked from commit 6de0091) Co-authored-by: Karl Godard <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: render loop speed increased to make up for removal of multiline per loop rendering optimzation.
Fixes: #142291
Checklist