-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terminal Output] bug fixes to text sizer and missed lines rendered issue. #142524
Conversation
…sts added to prevent future regressions
…button state). increased playback speed to make up for removal of multi line per frame rendering
@@ -39,6 +39,8 @@ describe('SessionView component', () => { | |||
dispatchEvent: jest.fn(), | |||
})), | |||
}); | |||
|
|||
global.ResizeObserver = require('resize-observer-polyfill'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -234,7 +234,7 @@ export const useXtermPlayer = ({ | |||
// there is some random race condition with the jump to feature that causes these calls to error out. | |||
} | |||
} else { | |||
linesToPrint = lines.slice(lineNumber, lineNumber + TTY_LINES_PER_FRAME); | |||
linesToPrint = lines.slice(lineNumber, lineNumber + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, it was an optimization in an attempt to limit the amount of state changes. caused more problems than solved..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
If rendering shows to be a problem for larger sections, we can think about other solutions, either using Throttle or requestAnimationFrame, then we can make playback faster, but internally we are optimizing when to render.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…e in multi container sessions on the same pod
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]> (cherry picked from commit 6de0091)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ssue. (#142524) (#142545) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]> (cherry picked from commit 6de0091) Co-authored-by: Karl Godard <[email protected]>
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]>
…ssue. (elastic#142524) * removed complex lines per frame logic. caused too many edge cases. tests added to prevent future regressions * fix fit to screen option (when changing from fullscreen to not. also button state). increased playback speed to make up for removal of multi line per frame rendering * fixed tests * removing tty loading technique due to problems with unique char_device in multi container sessions on the same pod Co-authored-by: Karl Godard <[email protected]>
Summary
Note: render loop speed increased to make up for removal of multiline per loop rendering optimzation.
Fixes: #142291
Checklist