-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add reduced time range option for formula #142709
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Yes. If we agree on that I'd say to change also the other tooltips to align to the same message (in another PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected, I checked few scenarios (all with and without reduced time range set on switch (1h
) to see if it's overwritten):
- count(reducedTimeRange='1d') - switch doesn't impact the result
- count(reducedTimeRange='1d') + 1 - switch doesn't impact the result
- count(reducedTimeRange='1d') + count(reducedTimeRange='1M') - switch doesn't impact the result
- count(reducedTimeRange='1d') + count() - switch impacts the result, the count() gets global switch value.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* ✅ Add tests for feature * ✨ Add feature and make tests work * ✨ Add more ui stuff * 🐛 Fix missing renders on advanced options change * 🔧 fix id issue * 👌 Shorter tooltip message
* ✅ Add tests for feature * ✨ Add feature and make tests work * ✨ Add more ui stuff * 🐛 Fix missing renders on advanced options change * 🔧 fix id issue * 👌 Shorter tooltip message
Summary
Fixes #138725
Introduced the reduced time range advanced option for Formula.
Some testing notes:
More notes:
debouced
hook used for inputs. This bug has been fixed in this PR.replaceColumn
has been created to regenerate in any case a formula column on change. Perhaps it can be optimized further, leaving it as a follow up after some profiling.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers