Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add reduced time range option for formula #142709

Merged
merged 10 commits into from
Oct 10, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Oct 5, 2022

Summary

Fixes #138725

Introduced the reduced time range advanced option for Formula.
Some testing notes:

  • the reduced time range introduced will only apply to supported operations who do not have it declared in place ( location option wins over global one)
  • when in formula, the label is no longer updated

Screenshot 2022-10-05 at 11 45 10

More notes:

  • 🐛 a bug was affecting Advanced Options when in Formula, which was only partially solved by the debouced hook used for inputs. This bug has been fixed in this PR.
    • A new branch for the replaceColumn has been created to regenerate in any case a formula column on change. Perhaps it can be optimized further, leaving it as a follow up after some profiling.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.6.0 labels Oct 5, 2022
@dej611 dej611 marked this pull request as ready for review October 6, 2022 10:00
@dej611 dej611 requested a review from a team as a code owner October 6, 2022 10:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@KOTungseth
Copy link
Contributor

Screenshot 2022-10-05 at 11 45 10

The provide reduced time range will be applied to the entire formula. assumes that there are multiple parts to the formula. Is that true?
If yes, how about shortening to:
Applies to the entire formula.

@dej611
Copy link
Contributor Author

dej611 commented Oct 10, 2022

The provide reduced time range will be applied to the entire formula. assumes that there are multiple parts to the formula. Is that true?

Yes. If we agree on that I'd say to change also the other tooltips to align to the same message (in another PR).

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected, I checked few scenarios (all with and without reduced time range set on switch (1h) to see if it's overwritten):

  • count(reducedTimeRange='1d') - switch doesn't impact the result
  • count(reducedTimeRange='1d') + 1 - switch doesn't impact the result
  • count(reducedTimeRange='1d') + count(reducedTimeRange='1M') - switch doesn't impact the result
  • count(reducedTimeRange='1d') + count() - switch impacts the result, the count() gets global switch value.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit e20c451 into elastic:main Oct 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 10, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
* ✅ Add tests for feature

* ✨ Add feature and make tests work

* ✨ Add more ui stuff

* 🐛 Fix missing renders on advanced options change

* 🔧 fix id issue

* 👌 Shorter tooltip message
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
* ✅ Add tests for feature

* ✨ Add feature and make tests work

* ✨ Add more ui stuff

* 🐛 Fix missing renders on advanced options change

* 🔧 fix id issue

* 👌 Shorter tooltip message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Reduced time range option for formula
6 participants