Tenor Implementation Master Issue

[ScoutHarris]

Implement Tenor to replace Giphy for third-party gif import.

Refs:

• Giphy removal PR.
• Tenor documentation.

Tasks:

• Add Feature Flag. (Add Tenor feature flag #13829)
• Implement Tenor support.
  • Tenor API credentials support (Tenor API credentials support #13842)
  • Implement Tenor client api (Implement Tenor client api #13843)
  • Tenor picker (Implement Tenor picker #13861)
• Add Tenor to Media Library options. (Tenor picker for Media library #13907)
• Add Tenor to Aztec editor media options. (Tenor Picker support for Aztec editor #13908)
• Add Tenor to block editor media options. (Tenor GIF picker for Gutenberg editor #13910)
• Add accessibility support. (no changes required)
• Add Tracks. Related P2 on the new way of doing this. (Tenor analytics support #13923)
• Animating GIFs in Tenor Picker (Animating GIFs in Tenor Picker #13941)
• Enable feature, add to release notes. (Enable the Tenor feature flag. #14297) (Released in 15.1)
• Mobile Guild P2 post. (https://wp.me/p7cLQ7-Ze)
• Remove any remaining Giphy support/files. (Remove Giphy code #14302)
• Remove Feature Flag.

[frosty]

Some remaining issues I observed while testing the main PR:

• Issue in the block editor where I saw search results appear briefly and then vanish. For some reason it happens for me every time with the search term 'blathers'.
• There's no animation or indication of a gif in the block editor – the classic editor shows a GIF badge in the top left of an image.
• Editing an image of course breaks the gif and turns it into a static image (it actually didn't even correctly replace the image for me in the classic editor when I tested it). I think we should probably disable image editing for gifs, or at the very least show a prompt when tapped saying that the image won't be animated any more.
  • We need to update to use the new media picker cell overlay prepareForReuse functionality to clear out the overlay contents between each use.

[ScoutHarris]

Hey @frosty . Regarding this issue:

There's no animation or indication of a gif in the block editor

I'm seeing the GIFs animate in the block editor. Is there a step I'm missing or something? I simply started a new post with the block editor and added a gif to an image block.

[ScoutHarris]

Hey @frosty .

We need to update to use the new media picker cell overlay prepareForReuse functionality to clear out the overlay contents between each use.

I'm not quite getting this one. Can you elaborate please?

[frosty]

I'm seeing the GIFs animate in the block editor.

Interesting! I just followed the same steps as you, but it doesn't animate 🤔 I've tried it with several, with the latest develop build, and they're all just static.

[frosty]

I'm not quite getting this one. Can you elaborate please?

@SergioEstevao recently added a prepareForReuse method to ReusableOverlayView: https://github.com/wordpress-mobile/MediaPicker-iOS/pull/351/files

We should implement that in TenorPicker.swift to clear out the overlay views (CachedAnimatedImageView) before they're reused, to ensure they don't show old content.