-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenor GIF picker for Gutenberg editor #13910
Tenor GIF picker for Gutenberg editor #13910
Conversation
# Conflicts: # WordPress/WordPress.xcodeproj/project.pbxproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ngoctr .
Sometimes when previewing a post while GIFs are loading, some GIFs don't end up in published post.
- While editing a post, select several GIFs.
- While they are loading, preview the post.
- Notice not all the GIFs appear in the preview.
- Close the preview and return to the post.
- After all the GIFs have loaded, preview again.
- Notice not all the GIFs are present.
- Publish the post.
- Notice not all the GIFs are present.
- Edit the post.
- This does show all the GIFS, including the ones missing from the published post.
@ScoutHarris I noticed the same issue with Stock Photos too, it's not just happened only with GIFs. There are weird URLs in my debug log: |
Aaaahh. Would you mind creating an issue in the gutenburg repo (if one doesn't already exist) and we'll reference that here. |
Sure, I will do that. If I do update the Post before previewing, then everything is working ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the known issue with some media not loading, this looks fine.
Thanks @ngoctr !
5fa137d
into
wordpress-mobile:feature/13803-tenor_integration
Well you know very well people are not that patient. How do you think I found it? 😆 |
Haha, I see 😃 Thanks @ScoutHarris for approving this. |
This added Tenor Picker support for Gutenberg editor as part of #13803.
Testing
First steps
.configure-files/wpcom_app_credentials
(TENOR_API_KEY line)rake dependencies
Verify Tenor support in Gutenberg Editor
There are other flows in the Block Editor also involved the Tenor Picker that you should also make tests:
PR submission checklist:
RELEASE-NOTES.txt
if necessary. (Will be in a separate PR)