Implement Tenor client api #13816
Closed
Implement Tenor client api #13816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to load ReaderTabView - Refactored ReaderTabView to use let constants for objects that should be immutable
… the divider to avoid temporary constraint breaks
…ss-iOS into feature/Reader-tabs-navigation
…ss-iOS into feature/Reader-tabs-navigation
- Update ReaderTabViewModel.swift, add a Tab Bar extension to sync topics with the backend in Core Data, and fetch them to populate the tab bar items - Update ReaderTabView, use the reader tab bar items retrieved from the view model - Update feature flag
…ss-iOS into feature/Reader-tabs-navigation
Also update Aztec to version 1.17.1
- Update FilterTabBar.swift, re-activate tabBarHeightConstraint after changing height value - Update ReaderTabView.swift, re-arranged properties by type - Update ReaderTabViewController.swift, removed nibName and bundle from init signature, set them to nil by default in super.init() call - Update ReaderHelpers.swift, add some clarifying comments in rearrange method
…ss-iOS into feature/Reader-tabs-navigation
# Conflicts: # Podfile.lock
This avoids a potential crash when the view has not yet fully loaded
…upButtonsView() and activateConstraints()
…berg/integrate_release_1.25.0 Update Gutenberg to 1.25.0 release
…ss-iOS into feature/Reader-tabs-navigation
Colors are now inline with design and change according to light/dark mode.
…re/Reader-tabs-navigation Uses reader Topics to populate the new Reader Tab Bar
…review-presentation-size Change iPad Post Preview presentation to fullscreen
…3735-searchcontroller-crash Safely unwrap searchController in Posts List
…/remove-segue-show2FA Remove the .show2FA segue and replace with programmatic nav
…edia-selection-via-other-apps Display Cancel button in "Other Apps" media browser
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement Tenor client API as part of 13803
PR submission checklist:
RELEASE-NOTES.txtif necessary.