Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg to 1.25.0 release #13779

Merged
merged 9 commits into from
Apr 3, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 31, 2020

Updates Gutenberg to release 1.25.0

To test:

  • Test the gutenberg editor using the pre-bundled package.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Also update Aztec to version 1.17.1
@SergioEstevao SergioEstevao added Gutenberg Editing and display of Gutenberg blocks. Releases labels Mar 31, 2020
@SergioEstevao SergioEstevao added this to the 14.6 milestone Mar 31, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 31, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Writing flow sanity tests:

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Edit: Fixed on 56402cc 🎉

@SergioEstevao - I'm still seeing the wrong font on Preformatted block.
Did this PR make it to the release? WordPress/gutenberg#21255

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Testing new features:

  • ✅ Added the Cover block
  • Improve icon on the "Take a Video" media option (Not on iOS)
  • ✅ Removed the dimming effect on unselected blocks (Inner blocks)
  • ✅ Add alignment options for Heading block
  • ✅ Implemented dropdown toolbar for alignment toolbar in Heading, Paragraph, Image, MediaText blocks
  • ✅ When editing link settings, tapping the keyboard return button now closes the settings panel as well as closing the keyboard.

@mkevins
Copy link
Contributor

mkevins commented Apr 2, 2020

Sanity tests for MediaText1-2-3-4, MultipleUpload-1, Shortcode-1 all behaving as expected. I did encounter a bug when I deviated slightly from the test path for uploading in airplane mode (image and video), which I've noted below.

Sanity tests (iOS):

MediaText-1

  • Media Text block - Insert image from device (failing) - steps

👆 Following the exact steps works, however, I encountered a bug when I turned on airplane mode prior to tapping "Choose from device": the upload progress is stuck, and the failure message never appears.

Screenshot
  • Media Text block - Close/Re-open post with an ongoing image upload - steps

MediaText-2

  • Media Text block - Insert video from device (cancel) - steps
  • Media Text block - Insert image from device (cancel) - steps

MediaText-3

  • Media Text block - Insert video from device (failing) - steps

👆 Just as the similar test-case for image uploading works, this hangs with no failure message if the upload is started with airplane mode on.

  • Media Text block - Close/Re-open post with an ongoing video upload - steps

MediaText-4

  • Media Text block - Media & Text alignment - steps
  • Media Text block - Vertical alignment - steps

MultipleUpload-1

  • Simultaneous uploads - steps

Shortcode-1

  • Shortcode block - Add a youtube link - steps

@pinarol
Copy link
Contributor

pinarol commented Apr 2, 2020

👆 Following the exact steps works, however, I encountered a bug when I turned on airplane mode prior to tapping "Choose from device": the upload progress is stuck, and the failure message never appears.

Thank you @mkevins ! I tried the same thing, looks like an intermittent issue, so not happening all the time. The good part is if you tap on the stuck upload it still shows the “Retry” option, only missing thing is the “Failed to insert media” indication on the image. I was able to see that label for a split second and then it gets lost. Could you open an issue and add to Mobile Gutenpages board?

IMO: Not a blocker for the release.

@SergioEstevao SergioEstevao merged commit a9105fb into develop Apr 3, 2020
@SergioEstevao SergioEstevao deleted the gutenberg/integrate_release_1.25.0 branch April 3, 2020 18:27
@mkevins
Copy link
Contributor

mkevins commented Apr 7, 2020

Could you open an issue and add to Mobile Gutenpages board?

Certainly! Just circling back to link the issue here for posterity: wordpress-mobile/gutenberg-mobile#2106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants