-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gutenberg to 1.25.0 release #13779
Conversation
Also update Aztec to version 1.17.1
You can trigger an installable build for these changes by visiting CircleCI here. |
Writing flow sanity tests:
|
Edit: Fixed on 56402cc 🎉 @SergioEstevao - I'm still seeing the wrong font on Preformatted block. |
Testing new features:
|
Sanity tests for MediaText1-2-3-4, MultipleUpload-1, Shortcode-1 all behaving as expected. I did encounter a bug when I deviated slightly from the test path for uploading in airplane mode (image and video), which I've noted below. Sanity tests (iOS): MediaText-1
👆 Following the exact steps works, however, I encountered a bug when I turned on airplane mode prior to tapping "Choose from device": the upload progress is stuck, and the failure message never appears.
MediaText-2
MediaText-3
👆 Just as the similar test-case for image uploading works, this hangs with no failure message if the upload is started with airplane mode on.
MediaText-4MultipleUpload-1
Shortcode-1
|
Thank you @mkevins ! I tried the same thing, looks like an intermittent issue, so not happening all the time. The good part is if you tap on the stuck upload it still shows the “Retry” option, only missing thing is the “Failed to insert media” indication on the image. I was able to see that label for a split second and then it gets lost. Could you open an issue and add to Mobile Gutenpages board? IMO: Not a blocker for the release. |
Certainly! Just circling back to link the issue here for posterity: wordpress-mobile/gutenberg-mobile#2106 |
Updates Gutenberg to release 1.25.0
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.