Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credentials to include Tenor API key #14295

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Jun 11, 2020

Ref #13803

This updates credentials files to include the Tenor API key from the secrets repo.

To test:

Verify the key is generated:

  • In the project directory, go to Derived Sources. In ApiCredential.m, verify there is an entry for tenorApiKey.

Verify GIF searching:

  • Go to Media > Add > Free GIF Library.
  • Enter a search term.
  • Verify search results are displayed.

Simulator Screen Shot - iPhone 11 Pro Max - 2020-06-11 at 10 23 31

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 15.1 milestone Jun 11, 2020
@ScoutHarris ScoutHarris self-assigned this Jun 11, 2020
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ In the project directory, go to Derived Sources. In ApiCredential.m, verify there is an entry for tenorApiKey.
✅ Verify search results are displayed.

@ScoutHarris
Copy link
Contributor Author

Thanks @jkmassel !

@ScoutHarris ScoutHarris merged commit a0a93a6 into develop Jun 11, 2020
@ScoutHarris ScoutHarris deleted the 13803-add_tenor_credentials branch June 11, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants