GIF search: correctly display partial page results. #14291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13803 (comment)
This fixes the issue noted in the referenced comment:
The problem was
TenorService
was loading an additional page when it didn't need to becauseTenorPageable
was telling it there was a next page. So, after correctly displaying the search results, the last fetch would return nothing, resulting in the no results message.This change determines if the last page was partial or not. If it was, stop loading.
To test:
blathers
orhammerhead
should do it.PR submission checklist:
RELEASE-NOTES.txt
if necessary.