Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in Block Editor when adding image #13911

Closed
ngoctr opened this issue Apr 16, 2020 · 2 comments · Fixed by #14277
Closed

Crash in Block Editor when adding image #13911

ngoctr opened this issue Apr 16, 2020 · 2 comments · Fixed by #14277
Assignees
@ceyhun
Labels
Media Posting/Editing [Type] Bug [Type] Crash

Comments

@ngoctr
Copy link
Contributor

ngoctr commented Apr 16, 2020 •
edited
Loading

This was found while working on #13803

Actual behavior

  1. Go to Site -> Posts, open a Post to edit with Block Editor (You will need to switch back to Block Editor if you are using Classic Editor
  2. Add an Image block, then add 2-3 photos from Free Photo Library (or Free GIF Library if you are using Tenor Implementation Master Issue #13803 branch)
  3. While selected images being uploaded, Previewing the post.
  4. Close the previewing, then add another Image Block, then select an image from Free Photo Library.
  5. When you tap Add button in the image picker, app crashed

Crash log

2020-04-16 11:40:24.595095+1000 WordPress[43897:1004610] *** Assertion failure in -[MediaService createMediaWith:blog:post:progress:thumbnailCallback:completion:], /Users/winter/Works/A8C/WordPress-iOS/WordPress/Classes/Services/MediaService.m:46
2020-04-16 11:40:24.624638+1000 WordPress[43897:1004610] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: blog.managedObjectContext == self.managedObjectContext'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff23e3dcce __exceptionPreprocess + 350
    1   libobjc.A.dylib                     0x00007fff50b3b9b2 objc_exception_throw + 48
    2   CoreFoundation                      0x00007fff23e3da48 +[NSException raise:format:arguments:] + 88
    3   Foundation                          0x00007fff258ac792 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
    4   WordPress                           0x000000010b3ee3f9 -[MediaService createMediaWith:blog:post:progress:thumbnailCallback:completion:] + 1113
    5   WordPress                           0x000000010c0e8076 $s9WordPress16MediaCoordinatorC03addC033_75C2DFAF7FEDF19BA73080809175E149LL4from4blog4post11coordinator13analyticsInfoSo0C0CSgAA15ExportableAsset_p_So4BlogCSo12AbstractPostCSgAA0c8ProgressD0CAA0c9AnalyticsP0VSgtF + 1382
    6   WordPress                           0x000000010c0e7ac8 $s9WordPress16MediaCoordinatorC03addC04from2to13analyticsInfoSo0C0CSgAA15ExportableAsset_p_So12AbstractPostCAA0c9AnalyticsI0VSgtF + 168
    7   WordPress                           0x000000010bd5dab2 $s9WordPress28GutenbergMediaInserterHelperC6insert15exportableAsset6sourceSo0D0CSgAA010ExportableI0_p_AA0D6SourceOtF + 242
    8   WordPress                           0x000000010b9b12d2 $s9WordPress20GutenbergStockPhotosC13insertOnBlock4withySayAA0dE5MediaCG_tF0C00J4InfoVSgAGXEfU_ + 258
    9   WordPress                           0x000000010b9b167c $s9WordPress20GutenbergStockPhotosC13insertOnBlock4withySayAA0dE5MediaCG_tF0C00J4InfoVSgAGXEfU_TA + 12
    10  WordPress                           0x000000010b9b169d $s9WordPress16StockPhotosMediaC9Gutenberg0E4InfoVSgs5Error_pIggozo_AcGsAH_pIegnrzo_TR + 29
    11  WordPress                           0x000000010b9b1704 $s9WordPress16StockPhotosMediaC9Gutenberg0E4InfoVSgs5Error_pIggozo_AcGsAH_pIegnrzo_TRTA + 20
    12  libswiftCore.dylib                  0x0000000111db3ddd $sSTsE10compactMapySayqd__Gqd__Sg7ElementQzKXEKlF + 733
    13  WordPress                           0x000000010b9b0d66 $s9WordPress20GutenbergStockPhotosC13insertOnBlock4withySayAA0dE5MediaCG_tF + 422
    14  WordPress                           0x000000010b9b1002 $s9WordPress20GutenbergStockPhotosC18insertSingleImagesyySayAA0dE5MediaCGF + 354
    15  WordPress                           0x000000010b9b096b $s9WordPress20GutenbergStockPhotosC05stockE6Picker_16didFinishPickingyAA0deG0C_SayAA0dE5MediaCGtF + 219
    16  WordPress                           0x000000010b9b1a99 $s9WordPress20GutenbergStockPhotosCAA0dE14PickerDelegateA2aDP05stockeF0_16didFinishPickingyAA0deF0C_SayAA0dE5MediaCGtFTW + 9
    17  WordPress                           0x000000010c0508a7 $s9WordPress17StockPhotosPickerC05mediaE10Controller_16didFinishPickingySo07WPMediae4ViewG0C_SaySo0K5Asset_pGtF + 487
    18  WordPress                           0x000000010c050df8 $s9WordPress17StockPhotosPickerC05mediaE10Controller_16didFinishPickingySo07WPMediae4ViewG0C_SaySo0K5Asset_pGtFTo + 120
    19  WordPress                           0x000000010cf7a372 -[WPNavigationMediaPickerViewController mediaPickerController:didFinishPickingAssets:] + 210
    20  WordPress                           0x000000010cf6c0f2 -[WPMediaPickerViewController onAddButtonPressed:] + 242
    21  UIKitCore                           0x00007fff48c1a4d5 -[UIApplication sendAction:to:from:forEvent:] + 83
    22  UIKitCore                           0x00007fff485cbc83 -[UIControl sendAction:to:forEvent:] + 223
    23  UIKitCore                           0x00007fff485cbfcb -[UIControl _sendActionsForEvents:withEvent:] + 396
    24  UIKitCore                           0x00007fff485caf3c -[UIControl touchesEnded:withEvent:] + 497
    25  UIKitCore                           0x00007fff48c55d10 -[UIWindow _sendTouchesForEvent:] + 1359
    26  UIKitCore                           0x00007fff48c57a95 -[UIWindow sendEvent:] + 4501
    27  UIKitCore                           0x00007fff48c31ed9 -[UIApplication sendEvent:] + 356
    28  UIKitCore                           0x00007fff48cbc336 __dispatchPreprocessedEventFromEventQueue + 7328
    29  UIKitCore                           0x00007fff48cbf502 __handleEventQueueInternal + 6565
    30  UIKitCore                           0x00007fff48cb606b __handleHIDEventFetcherDrain + 88
    31  CoreFoundation                      0x00007fff23da1c71 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
    32  CoreFoundation                      0x00007fff23da1b9c __CFRunLoopDoSource0 + 76
    33  CoreFoundation                      0x00007fff23da1374 __CFRunLoopDoSources0 + 180
    34  CoreFoundation                      0x00007fff23d9bf6e __CFRunLoopRun + 974
    35  CoreFoundation                      0x00007fff23d9b884 CFRunLoopRunSpecific + 404
    36  GraphicsServices                    0x00007fff38b5ac1a GSEventRunModal + 139
    37  UIKitCore                           0x00007fff48c19220 UIApplicationMain + 1605
    38  WordPress                           0x000000010c06fab4 main + 500
    39  libdyld.dylib                       0x00007fff519b910d start + 1
    40  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Tested on [iPhone/iPad], iOS [13.4], WPiOS [14.7 Debug run]
@elibud
Copy link
Contributor

elibud commented Jun 5, 2020

@hypest can you have someone from your team please look into this?

@ceyhun ceyhun self-assigned this Jun 8, 2020
@ceyhun ceyhun mentioned this issue Jun 9, 2020
Merged
3 tasks
@ScoutHarris
Copy link
Contributor

Fixed with #14277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceyhun ceyhun

Labels
Media Posting/Editing [Type] Bug [Type] Crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash in block editor when adding a second image wordpress-mobile/WordPress-iOS
4 participants
@ScoutHarris @ceyhun @elibud @ngoctr