Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tenor feature flag. #14513

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Remove Tenor feature flag. #14513

merged 1 commit into from
Jul 23, 2020

Conversation

ScoutHarris
Copy link
Contributor

Fixes #13803

This removes the tenor feature flag and associated checks.

To test:
Detailed testing steps can be found on #13949. In short, verify you can add GIFs from:

  • Media Library
  • Block Editor
  • Classic Editor

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 15.4 milestone Jul 23, 2020
@ScoutHarris ScoutHarris requested a review from Gio2018 July 23, 2020 01:08
@ScoutHarris ScoutHarris self-assigned this Jul 23, 2020
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Gio2018
Gio2018 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ScoutHarris ScoutHarris merged commit d47fbe8 into develop Jul 23, 2020
@ScoutHarris ScoutHarris deleted the feature/13803-remove_tenor_ff branch July 23, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gio2018 Gio2018 Gio2018 approved these changes

Assignees

@ScoutHarris ScoutHarris

Labels
None yet
Projects
None yet
Milestone
15.4
Development

Successfully merging this pull request may close these issues.

Tenor Implementation Master Issue
2 participants
@ScoutHarris @Gio2018