Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong analytics image source for Stock Photo in Gutenberg Editor #13940

Conversation

ngoctr
Copy link
Contributor

@ngoctr ngoctr commented Apr 18, 2020

This PR fixes an issue where the analytics source of stock photo images being sent as Giphy within Gutenberg Editor. The issue's found when I were working on #13803.

To test

  1. Go to Site -> Posts, open a Post to edit with Block Editor (you may need to switch if your default editor is the classic one)
  2. Add an image block, tap ADD IMAGE then choose Free Photo Library
  3. Search and select an image, then tap Add button at the bottom right.
  4. Notice the message 🔵 Tracked: editor_photo_added <blog_id: 174512392, bytes: 815818752, ext: jpeg, media_origin: not_identified, megapixels: 1, mime: image/jpeg, via: stock_photos> where the via is correctly pointed to stock_photos source.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ngoctr ngoctr changed the title Fixed analytics image source for Stock Photo being sent as Giphy Wrong analytics image source for Stock Photo in Gutenberg Editor Apr 18, 2020
@ScoutHarris ScoutHarris self-requested a review April 18, 2020 01:14
@ScoutHarris ScoutHarris added this to the 14.8 milestone Apr 18, 2020
@ScoutHarris ScoutHarris mentioned this pull request Apr 20, 2020
3 tasks
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing!

@ScoutHarris ScoutHarris merged commit 3e51da2 into wordpress-mobile:develop Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants