Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Giphy code #14302

Merged
merged 6 commits into from
Jun 12, 2020
Merged

Remove Giphy code #14302

merged 6 commits into from
Jun 12, 2020

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Jun 11, 2020

Ref #13803

(Sorry about all the pod PRs. Shared is the only one with actual changes, but I had to update the other two to satisfy dependencies.)

This removes all Giphy related code. The only remnants should be localized strings, which should get removed when translations are updated.

To test:
Giphy has been disabled for quite a while, so there should be no visible changes. So just make sure other media is still functional.

  • Verify the app builds and runs with no Giphy related warnings/errors.
  • Verify media import via Free Photo Library.
  • Verify media import via Free GIF Library.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 15.1 milestone Jun 11, 2020
@ScoutHarris ScoutHarris self-assigned this Jun 11, 2020
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 11, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris requested review from frosty and Gio2018 June 11, 2020 21:17
@github-actions
Copy link

github-actions bot commented Jun 11, 2020

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 8bbd606

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 11, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iPhone 11 Max Pro Simulator - 13.5 and worked as described.
Also, no traces of giphy were found in the code (except, like you said in the comments, for the Localizable.strings that will be updated automatically)
:shipit:

@ScoutHarris
Copy link
Contributor Author

Thanks @Gio2018 !

@ScoutHarris ScoutHarris merged commit dcfb9c0 into develop Jun 12, 2020
@ScoutHarris ScoutHarris deleted the issue/13803-remove_giphy_code branch June 12, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants