-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Giphy code #14302
Remove Giphy code #14302
Conversation
Generated by 🚫 dangerJS |
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iPhone 11 Max Pro Simulator - 13.5 and worked as described.
Also, no traces of giphy were found in the code (except, like you said in the comments, for the Localizable.strings that will be updated automatically)
Thanks @Gio2018 ! |
Ref #13803
(Sorry about all the pod PRs. Shared is the only one with actual changes, but I had to update the other two to satisfy dependencies.)
This removes all Giphy related code. The only remnants should be localized strings, which should get removed when translations are updated.
To test:
Giphy has been disabled for quite a while, so there should be no visible changes. So just make sure other media is still functional.
Free Photo Library
.Free GIF Library
.PR submission checklist:
RELEASE-NOTES.txt
if necessary.