Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media: Update the Giphy search prompt in editor for that context #10425

Closed
rachelmcr opened this issue Nov 7, 2018 · 4 comments
Closed

Media: Update the Giphy search prompt in editor for that context #10425

rachelmcr opened this issue Nov 7, 2018 · 4 comments

Comments

@rachelmcr
Copy link
Member

rachelmcr commented Nov 7, 2018

Expected behavior

I expect the Giphy search prompt to be tailored to the context where I see it (either in my site's Media section or the editor).

Actual behavior

In both places, the Giphy search prompt refers to my media library:

Search to find GIFs to add to your Media Library!

When I'm adding GIFs directly to a post in the editor, that prompt feels a bit off.

2018-11-07 17 12 52

Steps to reproduce the behavior

  1. Start a new post in the app.
  2. Tap the "+" add media icon.
  3. Tap "..." and select Giphy as the media source.
Tested on iPhone XS, iOS 12.0.1, WPiOS 11.2.0.20181107
@rachelmcr
Copy link
Member Author

While we're at it, I noticed the same messaging for the Free Photo Library and would suggest a similar enhancement there.

@stale
Copy link

stale bot commented Jan 17, 2020

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@stale stale bot added the [Status] Stale label Jan 17, 2020
@stale stale bot removed the [Status] Stale label Jun 16, 2020
@designsimply
Copy link
Contributor

Closing because Giphy was removed in #14302. Props @ScoutHarris. 🎉

@designsimply
Copy link
Contributor

designsimply commented Jun 16, 2020

Adding an additional note to say, discussed this in Slack and, even if you are adding an image from the Free GIF Library or the Free Photo Library it's true that it will add a copy of the image to the Media Library so the note is technically correct and might be worth mentioning to users that images added with those options will be available in the Media Library (and also take up space there).

That said, if you feel strongly, we can re-open this issue for a larger discussion!

cc @ScoutHarris 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants