-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media picker: Action sheet for other media sources appears out of place on iPad #10881
Comments
I noticed this happened when working on #13803. The reason is that the underlying anchor view for the popover has been disappeared when the keyboard being resigned. @frosty I made a quick fix to show the sheet in the center screen as follow. Please let me know if you are happy with this, so I will put it in the PR for #13803. Thanks James. |
…s position won't be misplaced wordpress-mobile#10881
Thanks @ngoctr! However, would it be possible to open a separate PR for that fix, as it's kind of distinct from the Tenor changes? |
Sure @frosty, it should be. I will submit a separate PR for this one. |
…s position won't be misplaced wordpress-mobile#10881
Fixed with #13841. |
Expected behavior
When I add media from another source (free photo library, Giphy, other apps) I expect the action sheet to choose the source to appear near the toolbar/bottom of the screen in the editor.
Actual behavior
When I tap the ellipsis to choose another media source:
The action sheet to choose the media source appears in the top left:
Steps to reproduce the behavior
Tested on [iPad Mini], iOS [12.0.1], WPiOS [11.6.0.20190116]
The text was updated successfully, but these errors were encountered: