Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media picker: Action sheet for other media sources appears out of place on iPad #10881

Closed
rachelmcr opened this issue Jan 23, 2019 · 4 comments
Closed

Comments

@rachelmcr
Copy link
Member

Expected behavior

When I add media from another source (free photo library, Giphy, other apps) I expect the action sheet to choose the source to appear near the toolbar/bottom of the screen in the editor.

Actual behavior

When I tap the ellipsis to choose another media source:

photo 23-01-2019 09 38 14

The action sheet to choose the media source appears in the top left:

photo 23-01-2019 09 38 18

Steps to reproduce the behavior

  1. Open the editor on an iPad.
  2. Tap in the post content area.
  3. Tap the + toolbar button to add media.
  4. Tap the ellipsis to add media from another source.
Tested on [iPad Mini], iOS [12.0.1], WPiOS [11.6.0.20190116]
@ngoctr
Copy link
Contributor

ngoctr commented Apr 7, 2020

I noticed this happened when working on #13803. The reason is that the underlying anchor view for the popover has been disappeared when the keyboard being resigned. @frosty I made a quick fix to show the sheet in the center screen as follow. Please let me know if you are happy with this, so I will put it in the PR for #13803. Thanks James.

image

ngoctr added a commit to ngoctr/WordPress-iOS that referenced this issue Apr 7, 2020
@frosty
Copy link
Contributor

frosty commented Apr 7, 2020

Thanks @ngoctr! However, would it be possible to open a separate PR for that fix, as it's kind of distinct from the Tenor changes?

@ngoctr
Copy link
Contributor

ngoctr commented Apr 7, 2020

Sure @frosty, it should be. I will submit a separate PR for this one.

@ScoutHarris
Copy link
Contributor

Fixed with #13841.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants