-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trino 446 release notes #21753
Add Trino 446 release notes #21753
Conversation
|
||
## BigQuery connector | ||
|
||
* {{breaking}} Enable `bigquery.arrow-serialization.enabled` by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... we shouldn't include a breaking change that requires adding --add-opens
options to the JVM. Why is that required? The implementation should not have to rely on users manually working around Java visibility rules. @ebyhr, we should revert this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to an apache arrow requirement. There is no workaround for it as far as I know. The same applies to snowflake connector which is using Arrow as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The context is we want to remove another Avro serialization eventually since it's slower than Arrow and keeping both code requires maintenance costs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a big problem. It means that those libraries are using internal JDK APIs that may disappear at any point.
Depending on such behavior may make it hard or impossible to update to new Java versions in the future. In the worst case, we may need to update to the next major Java version to fix security issues and be forced to break those connectors.
We did a lot of work when migrating to Java 11 to avoid having to use internal Java APIs to be where we are today. This is a step backwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martint yes it does and it's been problematic for some time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead with the release for now and we can revisit whether we want to revert this once we have alignment in the next couple of days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have to give arrow native memory? It is impossible for it to use heap memory? Is this code pulling in native libraries also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we fork arrow to use heap memory. I have no idea why they think they need native memory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dain native - no. ArrowBuf allocates and uses off heap memory. The idea is to allow to pass vectors to other languages but that's not an actual case in these connectors
this supports input removal. ({issue}`21349`) | ||
* Extend `QueryCompletionEvent` with various aggregated, per-stage, per-task | ||
distribution statistics. New information is available in | ||
`QueryCompletedEvent.statistics.taskStatistics`. ({issue}`21694`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is that? A JMX metric? A system metadata? Both?
018ab2c
to
0bdaa6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor items .. but good to go.
Description
Assemble the release notes for the upcoming Trino 446 release.
Verification for each pull request
Format: PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion
17 April 2024
18 April 2024
tests:hive
label #21612 ✅ rn ✅ docs19 April 2024
21 April 2024
timestamp_precision
session property #21567 ✅ rn ✅ docs22 April 2024
23 April 2024
24 April 2024
25 April 2024
table_changes
function #21698 ✅ rn ✅ docs26 April 2024
28 April 2024
29 April 2024
table_changes
Iceberg table function #21406 ✅ rn ✅ docs30 April 2024
1 May 2024