Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MemorySplit to record #21636

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 19, 2024

Currently based on #21632 to avoid code conflicts.

@findepi findepi marked this pull request as draft April 19, 2024 13:54
@cla-bot cla-bot bot added the cla-signed label Apr 19, 2024
@findepi
Copy link
Member Author

findepi commented Apr 19, 2024

Currently based on #21632 to avoid code conflicts.

not considered to be draft anymore, as the other PR is likely not going to be merged

@findepi findepi marked this pull request as ready for review April 19, 2024 14:20
@findepi findepi force-pushed the findepi/memory-split-record branch from 5e03c10 to de74959 Compare April 19, 2024 14:21
@findepi
Copy link
Member Author

findepi commented Apr 19, 2024

should be merged after #21631.
both PRs fix the test, but only the other PR fixes the engine problem

@findepi findepi marked this pull request as draft April 19, 2024 14:21
@findepi findepi requested a review from wendigo April 19, 2024 14:22
@findepi findepi force-pushed the findepi/memory-split-record branch from de74959 to 0f3179d Compare April 19, 2024 14:22
@findepi findepi marked this pull request as ready for review April 22, 2024 08:53
@findepi findepi merged commit 0ffd2e2 into trinodb:master Apr 22, 2024
95 checks passed
@findepi findepi deleted the findepi/memory-split-record branch April 22, 2024 08:53
@github-actions github-actions bot added this to the 446 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant