Revert "Convert Split to record" #21631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 12b8e5f. The commit introduced some bug to execution engine which could be reproduced by running `TestDistributedEngineOnlyQueries.testAssignUniqueId` with `@RepeatedTest(1000)`. The fact that tests execute in concurrency could be a factor in reproducing the problem.
findepi
force-pushed
the
findepi/revert-convert-split-to-record-f95cad
branch
from
f8c12e5 to
04a1d21
Compare
findepi
commented
Apr 19, 2024
|
#21632 looks like a better alternative |
|
No longer draft per @martint 's #21632 (comment). |
wendigo
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 12b8e5f. The commit introduced some bug to execution engine which could be reproduced by running
TestDistributedEngineOnlyQueries.testAssignUniqueIdwith@RepeatedTest(1000). The fact that tests execute in concurrency could be a factor in reproducing the problem.Fixes #21630
This also fixes probable performance issue -- https://github.com/trinodb/trino/pull/21583/files#r1572265677