Convert config properties to list-table in Prometheus documentation #21658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/prometheus-config
branch
from
d8aa565 to
76deb99
Compare
mosabua
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Looks good as a pure source reformat. If you want, you could also drop the third columns and inline the default values into the second column. That can sometimes work better in terms of rendering, especially if only a few values have defaults. In this case both could work.
If you want to also reword the descriptions I can provide feedback, but this PR is good to go as it stands as well.
|
Let me merge as-is. Please feel free to send the follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.