Fix compilation of SQL functions with labels #21691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/routines
branch
2 times, most recently
from
cabccce to
fb6db65
Compare
findepi
changed the title
losipiuk
reviewed
Apr 24, 2024
core/trino-main/src/test/java/io/trino/sql/routine/TestSqlFunctions.java
Show resolved
Hide resolved
There are tests for WHILE and REPEAT, add one for LOOP.
findepi
force-pushed
the
findepi/routines
branch
from
fb6db65 to
e7432ba
Compare
electrum
approved these changes
Apr 24, 2024
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineCompiler.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineCompiler.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutinePlanner.java
Outdated
Show resolved
Hide resolved
The labels are used for LEAVE, ITERATE inside LOOP, REPEAT or WHILE. When generating function bytecode, the `SqlRoutineCompiler` relied on identity of `IrLabel` objects, which is maintained by the `SqlRoutinePlanner`. However, if the function IR is transferred to a worker, the identity is lost which was resulting in function compilation error. This commit fixes this by generating unique labels names in the function planner and identifying IR labels by value in the function compiler.
findepi
force-pushed
the
findepi/routines
branch
from
e7432ba to
9ac8ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labels are used for LEAVE, ITERATE inside LOOP, REPEAT or WHILE.
When generating function bytecode, the
SqlRoutineCompilerrelied onidentity of
IrLabelobjects, which is maintained by theSqlRoutinePlanner. However, if the function IR is transferred to aworker, the identity is lost which was resulting in function compilation
error. This commit fixes this by generating unique labels names in the
function planner and identifying IR labels by value in the function
compiler.
Fixes #21682