Fix spurious function compilation error #21686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, the function compiler sometimes failed with "break target does not exist" exception. This was reproducible only in distributed execution.
findepi
force-pushed
the
findepi/fix-spurious-function-compilation-error-18946a
branch
from
5bed93f to
43b64be
Compare
wendigo
approved these changes
Apr 24, 2024
findepi
commented
Apr 24, 2024
| private final Map<IrLabel, LabelNode> continueLabels = new IdentityHashMap<>(); | ||
| private final Map<IrLabel, LabelNode> breakLabels = new IdentityHashMap<>(); | ||
| private final Map<IrLabel, LabelNode> continueLabels = new HashMap<>(); | ||
| private final Map<IrLabel, LabelNode> breakLabels = new HashMap<>(); |
There was a problem hiding this comment.
this won't work when function body has same label multiple times.
see TestSqlFunctions.testReuseLabels
|
superseded by #21691 |
findepi
deleted the
findepi/fix-spurious-function-compilation-error-18946a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, the function compiler sometimes failed with "break target does not exist" exception. This was reproducible only in distributed execution.
Fixes #21682