Use enhanced switch #21578
Merged
Use enhanced switch #21578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
added
the
no-release-notes
github-actions
bot
added
tests:hive
hudi
wendigo
commented
Apr 17, 2024
| case LOOKUP_SOURCE_BUILT -> lookupSourceNotNeeded.orElseThrow(() -> new IllegalStateException("Lookup source built, but disposal future not set")); | ||
| case INPUT_SPILLED -> spilledLookupSourceHandle.getUnspillingOrDisposeRequested(); | ||
| case INPUT_UNSPILLING -> unspillInProgress.map(HashBuilderOperator::asVoid) | ||
| .orElseThrow(() -> new IllegalStateException("Unspilling in progress, but unspilling future not set")); |
There was a problem hiding this comment.
move to previous line
| case AND: | ||
| case OR: | ||
| case COALESCE: | ||
| // All the arguments after the first one are assumed to be conditionally evaluated |
| case BETWEEN: | ||
| generator = new BetweenCodeGenerator(specialForm); | ||
| break; | ||
| new SwitchCodeGenerator(specialForm); |
| return DoubleOperators.castToVarchar(UNBOUNDED_LENGTH, parser.getDoubleValue()); | ||
| case VALUE_NUMBER_INT: | ||
| DoubleOperators.castToVarchar(UNBOUNDED_LENGTH, parser.getDoubleValue()); | ||
| case VALUE_NUMBER_INT -> |
| default: | ||
| throw new JsonCastException(format("Unexpected token when cast to %s: %s", StandardTypes.REAL, parser.getText())); | ||
| } | ||
| (long) floatToRawIntBits(parser.getFloatValue()); |
| // org.apache.hadoop.hive.ql.exec.Utilities.getBucketingVersion is more permissive and treats any non-number as "1" | ||
| throw new TrinoException(StandardErrorCode.NOT_SUPPORTED, format("Unsupported bucketing version: '%s'", bucketingVersion)); | ||
| } | ||
| // org.apache.hadoop.hive.ql.exec.Utilities.getBucketingVersion is more permissive and treats any non-number as "1" |
| case DESC_NULLS_LAST: | ||
| return switch (sortItem.sortOrder()) { | ||
| // In MariaDB ASC implies NULLS FIRST | ||
| case ASC_NULLS_FIRST, DESC_NULLS_LAST -> | ||
| // In MariaDB DESC implies NULLS LAST |
wendigo
force-pushed
the
serafin/enhanced-switchof
branch
2 times, most recently
from
0141df9 to
9e11d12
Compare
wendigo
force-pushed
the
serafin/enhanced-switchof
branch
from
9e11d12 to
a6aa76e
Compare
|
@findepi it's green after rebasing :) Please review |
losipiuk
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.