Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a message if file system caching is disabled on coordinator #21666

Merged

Conversation

developer-x
Copy link
Member

@developer-x developer-x commented Apr 22, 2024

Description

If a connector does not support caching on a Coordinator, Trino instantiates Alluxio JMX statistics but quietly disables caching. As a result, it appears that caching is instantiated and is operating. Consequently, it's really confusing when caching doesn't work but there is no indication why.

This PR will issue a warning on startup to let the user know that caching has been disabled for the Coordinator.

Considering this is a trivial PR, I didn't create a ticket. But if that is appropriate, I will open an issue.

Additional context and related issues

N/A

Release notes

(x) This is just a logging message, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented Apr 22, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Andrew Hall.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ebyhr ebyhr changed the title Log a message if caching is disabled Log a message if file system caching is disabled on coordinator Apr 23, 2024
Copy link

cla-bot bot commented Apr 23, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Andrew Hall.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ebyhr
Copy link
Member

ebyhr commented Apr 24, 2024

Please submit CLA if you haven't sent it.

@developer-x
Copy link
Member Author

developer-x commented Apr 24, 2024 via email

@developer-x developer-x marked this pull request as ready for review April 29, 2024 17:16
@developer-x developer-x requested a review from ebyhr April 29, 2024 17:16
@ebyhr ebyhr force-pushed the refactor/add-logging-when-caching-disabled branch from 7a64357 to d46eec3 Compare April 29, 2024 21:37
@cla-bot cla-bot bot added the cla-signed label Apr 29, 2024
@ebyhr ebyhr merged commit a0103b1 into trinodb:master Apr 29, 2024
59 checks passed
@github-actions github-actions bot added this to the 446 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants