Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a message if file system caching is disabled on coordinator #21666

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Log a message if file system caching is disabled on coordinator #21666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/trino-filesystem-cache-alluxio/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@
<artifactId>configuration</artifactId>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>stats</artifactId>
Expand Down
4 changes: 4 additions & 0 deletions ...-alluxio/src/main/java/io/trino/filesystem/alluxio/AlluxioCoordinatorFileSystemCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import alluxio.conf.AlluxioProperties;
import alluxio.conf.InstancedConfiguration;
import com.google.inject.Inject;
import io.airlift.log.Logger;
import io.opentelemetry.api.trace.Tracer;
import io.trino.filesystem.Location;
import io.trino.filesystem.TrinoInput;
Expand All @@ -35,6 +36,8 @@
public class AlluxioCoordinatorFileSystemCache
implements TrinoFileSystemCache
{
private static final Logger log = Logger.get(AlluxioCoordinatorFileSystemCache.class);

private final Optional<AlluxioFileSystemCache> alluxioFileSystemCache;

@Inject
Expand All @@ -49,6 +52,7 @@ public AlluxioCoordinatorFileSystemCache(
alluxioFileSystemCache = Optional.of(new AlluxioFileSystemCache(tracer, config, statistics));
}
else {
log.debug("File system cache is disabled on a coordinator");
alluxioFileSystemCache = Optional.empty();
try {
CacheManager cacheManager = CacheManager.Factory.create(new InstancedConfiguration(new AlluxioProperties()));
Expand Down