Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax condition for allowing writer tasks splitting #21661

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

losipiuk
Copy link
Member

@losipiuk losipiuk commented Apr 22, 2024

Current condition which governed if given partition can be split between multiple writer tasks allowed only SCALED_WRITER_HASH_DISTRIBUTION. This effectively disabled writing single partition from multiple writer tasks if connector based partitioning was used, like e.g. Icebergs
day(some_timestamp_column)

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# General
* Improve performance of inserts into partitioned tables when when `retry_policy` is set to `TASK`. ({issue}`21661 `)

Current condition which governed if given partition can be split between
multiple writer tasks allowed only SCALED_WRITER_HASH_DISTRIBUTION. This
effectively disabled writing single partition from multiple writer tasks
if connector based partitioning was used, like e.g. Icebergs
  day(some_timestamp_column)
@losipiuk losipiuk force-pushed the lo/fte-scale-writers branch from 6512781 to c41df47 Compare April 22, 2024 17:06
@sopel39
Copy link
Member

sopel39 commented Apr 22, 2024

easy fix. Thx!

@losipiuk losipiuk merged commit c920022 into trinodb:master Apr 23, 2024
95 checks passed
@github-actions github-actions bot added this to the 446 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants