Use getSizeInBytes rather than getRetainedSizeInBytes #21653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For processed data getSizeInBytes should be used
sopel39
added
the
no-release-notes
findepi
approved these changes
Apr 22, 2024
| @@ -171,6 +171,6 @@ private long sendPageToPartition(Consumer<Page> buffer, Page pageSplit) | |||
| long retainedSizeInBytes = pageSplit.getRetainedSizeInBytes(); | |||
| memoryManager.updateMemoryUsage(retainedSizeInBytes); | |||
| buffer.accept(pageSplit); | |||
| return retainedSizeInBytes; | |||
| return pageSplit.getSizeInBytes(); | |||
There was a problem hiding this comment.
What's wrong about the existing code ?
We're calling page.compact() or page.copyPositions before sendPageToPartition, so what difference will this change make ?
There was a problem hiding this comment.
getRetainedSizeInBytes does not equal getSizeInBytes after compact or copyPositions. An example is dictionary. getSizeInBytes was always used to measure flow of data
There was a problem hiding this comment.
If this is just about measuring data processed, then why don't we call getSizeInBytes once on the full Page before splitting it rather than calling it on each partitioned Page and then adding that up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For processed data getSizeInBytes should be used
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: