v12.13.2 proposal #30865
Closed
v12.13.2 proposal #30865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #30220 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This is the certdata.txt[0] from NSS 3.47, released on 2019-10-21. This is the version of NSS that will ship in Firefox 71 on 2019-12-10. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_47_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #30195 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: Certificates removed: - Certplus Class 2 Primary CA - Deutsche Telekom Root CA 2 PR-URL: #30195 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This would otherwise sometimes just print relatively useless information about the value in question, such as `[object Object]`. PR-URL: #30167 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: David Carlier <[email protected]>
Do not accept the BOM if it comes from a different encoding, and only discard the BOM after it has actually been read (including when it is spread over multiple chunks in streaming mode). Fixes: #25315 PR-URL: #30132 Reviewed-By: Gus Caplan <[email protected]>
This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: #27220 PR-URL: #30098 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
This makes the actual behaviour match the documented (and arguably the correct) behaviour. PR-URL: #30230 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Since this code runs during process and Worker shutdown, it should not call user-provided code and thereby e.g. provide a way to break out of `worker.terminate()`. PR-URL: #30228 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
`writing-tests.md` states to use arrow functions when appropriate. This updates the examples to do that. Further, this syncs the docs with what's found in [`test/parallel/test-http-agent-null.js`](https://github.com/nodejs/node/blob/master/test/parallel/test-http-agent-null.js) PR-URL: #30126 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This has been around for a long time, and the underlying V8 API has become stable as well a while ago. PR-URL: #30234 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214 Fixes: #29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Move a handful of inactive Collaborators to emeriti. PR-URL: #30243 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
If `asyncReset()` is used to specify an alternative resource object to mark a re-used socket in the HTTP Agent implementation, store that object and keep it alive, because domains rely on GC tracking for resource objects to manage their own lifetimes, and previously that resource object might have been garbage-collected too early, leading to crashes. Fixes: #30122 PR-URL: #30196 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This makes it possible to tell whether a signal is being tracked in JS. PR-URL: #30229 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Run `EndStartedProfilers` on Environment teardown. This is part of a series of changes to make embedding easier, by requiring fewer internal methods to build a fully functioning Node.js instance. PR-URL: #30229 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Run inspector cleanup code on Environment teardown. This is part of a series of changes to make embedding easier, by requiring fewer internal methods to build a fully functioning Node.js instance. PR-URL: #30229 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
This makes more sense than releasing and re-wrapping the raw pointer. PR-URL: #30229 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
This is part of a series of changes to make embedding easier, by requiring fewer internal methods to build a fully functioning Node.js instance. This also aligns the worker_threads code with the main thread code. PR-URL: #30229 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
This was previously done inconsistently, sometimes before, sometimes after emitting the event. PR-URL: #30210 Fixes: #30209 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This avoids piling up `'listening'` event listeners if `.bind()` fails repeatedly. Fixes: #30209 PR-URL: #30210 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This consists of some hopefully-uncontroversial simplifications/clarifications to the text. The one substantial change is to update Node.js Board of Directors to be the OpenJS Board of Directors. PR-URL: #30259 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This test occasionally fails on macOS with the following error
```
events.js:187
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:201:27)
Emitted 'error' event on TLSSocket instance at:
at emitErrorNT (internal/streams/destroy.js:84:8)
at processTicksAndRejections (internal/process/task_queues.js:80:21) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
}
```
Fix it by making the client send the close_notify alert instead of the
server.
PR-URL: #30202
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Store the result of excetuting the function in variable. Instead of excetuting it for multiple times. PR-URL: #30303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fixes: #30245 PR-URL: #30256 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jan Krems <[email protected]>
PR-URL: #30299 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #30301 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #30321 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Changed a variable declaration. PR-URL: #30320 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #30318 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Refs: nodejs/code-and-learn#97 PR-URL: #30261 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
There is currently no test that confirms that an invalid TLS protocol results in ERR_TLS_INVALID_PROTOCOL_VERSION. Add tests to check this for the `minVersion` and `maxVersion` options in `createSecureContext()`. Refs: https://codecov.io/gh/nodejs/node/src/c14c476614e3134867ddb997bdfe5a41ba668175/lib/_tls_common.js#L56 Refs: https://coverage.nodejs.org/coverage-c14c476614e31348/lib/_tls_common.js.html#L56 PR-URL: #30741 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
added
build
Notable changes: - crypto: fix key requirements in asymmetric cipher (Tobias Nießen) #30249 - deps: - update llhttp to 2.0.1 (Fedor Indutny) #30553 - upgrade npm to 6.13.1 (claudiahdz) #30533 - update nghttp2 to 1.40.0 (gengjiawen) #30493 - v8: mark serdes API as stable (Anna Henningsen) #30234 PR-URL: #30865
BethGriggs
force-pushed
the
v12.13.2-proposal
branch
from
3185b6f
to
d02ac1c
Compare
|
As noted in #30109, there's a failing test on freebsd. |
|
Checking with v12.x: https://ci.nodejs.org/view/All/job/node-test-commit-freebsd/30067/ |
|
Is someone able to validate that #30346 is correct for 12.x? |
richardlau
previously approved these changes
Dec 9, 2019
Comment on lines
+219
to
+220
| * [Node.js 13](https://github.com/nodejs/node/blob/v13.x/BUILDING.md) | ||
| * [Node.js 12](https://github.com/nodejs/node/blob/v12.x/BUILDING.md) |
There was a problem hiding this comment.
Technically these two are not "older versions of Node.js" but I don't particularly object to the links being here.
|
@richardlau what do you think about the test that is consistently failing on FreeBSD only? |
Fair point. I've dismissed my review pending further investigation. |
Probably worth noting that FreeBSD was downgraded to an experimental platform in Node.js 12 so in theory test failures there do not block releases (we don't build FreeBSD binaries for distribution on https://nodejs.org/en/download/, for example). But it would be good to understand what's going on here. (Edit: discussion about potentially restoring FreeBSD tier 2 status: nodejs/build#1791) cc @nodejs/platform-freebsd |
I confirm. The methods were removed in V8 6.9 (v8/v8@313bc6d). v12.0.0 had V8 7.4. |
|
I imagine this should add d8fc0ae. |
Sounds like the npm update will be going out in a security release: nodejs/nodejs.org#2822 |
|
Since 12.14.0 has been released, should this be closed? Or updated to be a 12.14.1 release? |
|
Closing in favour of #31069 (I don't think you can change the PR branch and I'd like the version numbers to match) |
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now #31069
TBD, Version 12.13.2 'Erbium' (LTS), @BethGriggs
Notable changes
Commits
0e105bd5b3] - assert: replace var with let in lib/assert.js (PerfectPan) #302612ad7003f8d] - benchmark: use let instead of var in async_hooks (dnlup) #304707d113af552] - benchmark: use let instead of var in assert (dnlup) #304503e588713cc] - benchmark,doc,lib,test: prepare for padding lint rule (Rich Trott) #30696f0d43929f2] - buffer: fix 6-byte writeUIntBE() range check (Brian White) #304594ec0b74168] - buffer: change var to let (Vladislav Botvin) #30292e8b06e411f] - build: store cache on timed out builds on Travis (Richard Lau) #30469b18c8d3702] - build,win: propagate error codes in vcbuild (João Reis) #307248dd5eec5e2] - build,win: add test-ci-native and test-ci-js (João Reis) #30724a2ef66917e] - child_process: document kill() return value (cjihrig) #30669a7a71d4d82] - child_process: replace var with let/const (dnlup) #30389938b894423] - child_process: replace var with const/let in internal/child_process.js (Luis Camargo) #30414a31ace5eb7] - cluster: replace vars in child.js (EmaSuriano) #30383bd78c4f275] - cluster: replace var with let (Herrmann, Rene R. (656)) #30425863f7722f0] - cluster: replace var by let in shared_handle.js (poutch) #304025c72cc30a8] - cluster: destruct primordials in lib/internal/cluster/worker.js (peze) #3024618db45101c] - crypto: remove redundant validateUint32 argument (Tobias Nießen) #30579be0b53d4b2] - crypto: fix key requirements in asymmetric cipher (Tobias Nießen) #30249b1f4507862] - crypto: update root certificates (AshCripps) #301958a92830fd3] - deps: update llhttp to 2.0.1 (Fedor Indutny) #30553746c67d13b] - deps: upgrade npm to 6.13.1 (claudiahdz) #305332960ef186b] - deps: update nghttp2 to 1.40.0 (gengjiawen) #304935b2e0f54fc] - deps: update npm to 6.13.0 (Ruy Adorno) #3027129c819979b] - dgram: remove listeners on bind error (Anna Henningsen) #30210aa30eb5182] - dgram: reset bind state before emitting error (Anna Henningsen) #30210053c179571] - dns: use length for building TXT string (Anna Henningsen) #306900828154725] - dns: switch var to const/let (Dmitriy Kikinskiy) #3030298799d480d] - doc: fix typographical error (Rich Trott) #30735d7f1b0cd46] - doc: revise REPL uncaught exception text (Rich Trott) #307298eecd8a498] - doc: update signature algorithm in release doc (Myles Borins) #306730433ed44ae] - doc: update README.md to fix active/maint times (Michael Dawson) #30707898f236fb4] - doc: update socket.bufferSize text (Rich Trott) #307231818d9cbde] - doc: note that buf.buffer's contents might differ (AJ Jordan) #2965154cf114f91] - doc: clarify IncomingMessage.destroy() description (Sam Foxman) #30255fcae355b43] - doc: fixed a typo in process.md (Harendra Singh) #30277a396a5afd9] - doc: documenting a bit more FreeBSD case (David Carlier) #3032556772357b8] - doc: add missing 'added' versions to module.builtinModules (Thomas Watson) #305625340a2d9b4] - doc: address nits for src/README.md (Anna Henningsen) #3069344b474dc85] - doc: revise socket.connect() note (Rich Trott) #3069174e8902f01] - doc: remove "this API is unstable" note for v8 serdes API (bruce-one) #30631857669feeb] - doc: minor updates to releases.md (Beth Griggs) #30636ec504e3814] - doc: add 13 and 12 to previous versions (Andrew Hughes) #3059089f6ead222] - doc: update AUTHORS list (Gus Caplan) #306725be20b4948] - doc: add explanation why keep var with for loop (Lucas Recknagel) #303802acf6537d4] - doc: document "Resume Build" limitation (Richard Lau) #306042eaa940b6b] - doc: add note of caution about non-conforming streams (Robert Nagy) #2989577cbf09c2d] - doc: add note about debugging worker_threads (Denys Otrishko) #3059451a92b9050] - doc: add mention for using promisify on class methods (Denys Otrishko) #3035589f28cc0a6] - doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE (Denys Otrishko) #30371a992135af2] - doc: fix overriding of prefix option (Luigi Pinca) #305188bb232fb0e] - doc: adds NO_COLOR to assert doc page (Shobhit Chittora) #30483833cb002db] - doc: document timed out Travis CI builds (Richard Lau) #30469325dc23338] - doc: replace const / var with let (Duncan Healy) #30446c722421922] - doc: update 8.x to 10.x in backporting guide (garygsc) #304819d6c293966] - doc: createRequire can take import.meta.url directly (Geoffrey Booth) #304951ef1f4fc6d] - doc: add entry to url.parse() changes metadata (Luigi Pinca) #3034804ffa49a84] - doc: simplify text in pull-requests.md (Rich Trott) #304585c88500902] - doc: remove "multiple variants" from BUILDING.md (Rich Trott) #30366a7d552c4d3] - doc: remove "maintenance is supported by" text in BUILDING.md (Rich Trott) #30365671e028f27] - doc: add lookup to http.request() options (Luigi Pinca) #303538274875f46] - doc: fix up N-API doc (Michael Dawson) #3025460a0f1ed74] - doc: add link to node-code-ide-configs in testing (Kamat, Trivikram) #24012cf891002e4] - doc: update GOVERNANCE.md (Rich Trott) #30259557ad1a63d] - doc: move inactive Collaborators to emeriti (Rich Trott) #3024363f937d7ca] - doc: update examples in writing-tests.md (garygsc) #3012677abcad72e] - doc, console: remove non-existant methods from docs (Simon Schick) #30346879f57d523] - doc,meta: allow Travis results for doc/comment changes (Rich Trott) #30330fa5c7e5201] - doc,meta: remove wait period for npm pull requests (Rich Trott) #303296e9a1b2900] - domain: rename var to let and const (Maria Stogova) #303123be9b22348] - encoding: make TextDecoder handle BOM correctly (Anna Henningsen) #30132447c7a1192] - events: improve performance caused by primordials (guzhizhou) #3057700008590ca] - fs: change var to let (Àlvar Pérez) #30407d7d4fe1ef8] - fs: cover fs.opendir ERR_INVALID_CALLBACK (Vladislav Botvin) #30307c01a7fb564] - fs: change var to let (Nadya) #30318e2f8d23c1a] - http: set socket.server unconditionally (Anna Henningsen) #30571c8df932df1] - http: replace var with let (Guilherme Goncalves) #30421d0d891348b] - http: destructure primordials in lib/_http_server.js (Artem Maksimov) #3031598963f2a0e] - http: revise _http_server.js (telenord) #302792ece4fe310] - http: http_common rename var to let and const (telenord) #3028870cf4d2ff4] - http: http_incoming rename var to let and const (telenord) #30285f0994c618d] - http: replace vars with lets and consts in lib/_http_agent.js (palmires) #303012bd32a830b] - http,async_hooks: keep resource object alive from socket (Anna Henningsen) #30196e1b6b33355] - http2: fix session memory accounting after pausing (Michael Lehenbauer) #3068449f355810b] - http2: change var to let compact.js (Maria Emmanouil) #30392f1569f314d] - http2: core.js replace var with let (Daniel Schuech) #304032a44ff5921] - http2: replace var with let/const (Paolo Ceschi Berrini) #30417984b3c9b04] - http2: remove duplicated assertIsObject (ZYSzys) #3054152604fdcca] - https: change var to let in lib/https.js (galina.prokofeva) #3032061fc7548fa] - inspector: properly shut down uv_async_t (Anna Henningsen) #30612363391e378] - lib: use let instead of var (Shubham Chaturvedi) #303756ff34a5c2a] - lib: replace var with let/const (jens-cappelle) #30391ef3ab3749d] - lib: replace var w/ let (Chris Oyler) #30386a3531797d5] - lib: replace var with let/const (Tijl Claessens) #30390ab25a82770] - lib: adding perf notes js_stream_socket.js (ryan jarvinen) #304156d63b56a1f] - lib: replace var with let (Dennis Saenger) #3039606251a4183] - lib: main_thread_only change var to let (matijagaspar) #30398ff9adef57e] - lib: change var to let in stream_base_commons (Kyriakos Markakis) #3042668e8cd3b15] - lib: use let instead of var (Semir Ajruli) #30424640cde110f] - lib: changed var to let (Oliver Belaifa) #304271d6ee8bf6b] - lib: replace var with let/const (Dries Stelten) #30409b540ee0fae] - lib: change var to let (Dimitris Ktistakis) #3040817db4e3ee7] - lib: replace var with let/const (Tembrechts) #3040406540546fe] - lib: replace var to let in cli_table.js (Jing Lin) #30400e75498b48d] - lib: replace var with let (David OLIVIER) #303817aa999b8ba] - lib: replace var with let and const in readline.js (VinceOPS) #30377a2df87cc80] - lib: change var to let/const in internal/querystring.js (Artem Maksimov) #302866908a84256] - lib: change var to let in internal/streams (Kyriakos Markakis) #3043056c57d8024] - lib: replace var with let/const (Kenza Houmani) #3044047fa16497a] - lib: change var to let in string_decoder (mkdorff) #303937faa7d1ff9] - lib: replaced var to let in lib/v8.js (Vadim Gorbachev) #303050d8c58f0e1] - lib: change var to let in lib/_stream_duplex.js (Ilia Safronov) #30297ec227c99fc] - module: fix for empty object in InternalModuleReadJSON (Guy Bedford) #30256499fb42afe] - n-api: detach external ArrayBuffers on env exit (Anna Henningsen) #3055136f7f888b8] - n-api: add missed nullptr check in napi_has_own_property (Denys Otrishko) #3062678b2d86405] - net: replaced vars to lets and consts (nathias) #304016894703646] - net: destructure primordials (Guilherme Goncalves) #30447c199570839] - net: replaced vars to lets and consts (alexahdp) #302872f2a8aa373] - path: replace var with let in lib/path.js (peze) #302602c29db1dd5] - process: replace var with let/const (Jesper Ek) #3038238d5feaf4f] - process: replace vars in per_thread.js (EmaSuriano) #3038575cb026e2a] - process: add coverage tests for sourceMapFromDataUrl method (Nolik) #303195cbe7c2c8c] - process: make source map getter resistant against prototype tampering (Anna Henningsen) #302288d9080ae0b] - querystring: replace var with let/const (Raoul Jaeckel) #30429b10b72eb03] - readline: change var to let (dnlup) #304356078d23c6c] - repl: change var to let (Oliver Belaifa) #3042843f9137dd6] - src: remove unused variable in node_dir.cc (gengjiawen) #3026743545f3692] - src: cleanup unused headers (Alexandre Ferrando) #30328aa65e4bedd] - src: replaced var with let (Aldo Ambrosioni) #30397bf43bf5417] - src: fix signal handler crash on close (Shelley Vohr) #3058265af83656b] - src: add file name to 'Module did not self-register' error (Jeremy Apthorp) #30125e0982f754d] - src: enhance feature accessCHECKs during bootstrap (Anna Henningsen) #3045256b3205364] - src: lib/internal/timers.js var -> let/const (Nikolay Krashnikov) #303147267396aeb] - src: persist strings that are used multiple times in the environment (Vadim Gorbachev) #30321f97f1cadcc] - src: run RunBeforeExitCallbacks as part of EmitBeforeExit (Anna Henningsen) #30229b40eedeb61] - src: use unique_ptr for InitializeInspector() (Anna Henningsen) #3022979713ed8e5] - src: make WaitForInspectorDisconnect an exit hook (Anna Henningsen) #30229619b718071] - src: make EndStartedProfilers an exit hook (Anna Henningsen) #302295ec35730bb] - src: track no of active JS signal handlers (Anna Henningsen) #30229338d216336] - src: make AtExit() callbacks run in reverse order (Anna Henningsen) #30230bca0e0f2be] - src: remove unimplemented method from node.h (Anna Henningsen) #300989de7196774] - src,doc: fix broken links (cjihrig) #3066272aecd7fa5] - src,doc: add C++ internals documentation (Anna Henningsen) #30552b042e7fd68] - stream: improve performance for sync write finishes (Anna Henningsen) #30710f212dd9a29] - stream: replace var with let (daern91) #30379b5625f65b2] - stream: increase MAX_HWM (Robert Nagy) #29938ac6ff770fa] - test: add coverage for ERR_TLS_INVALID_PROTOCOL_VERSION (Rich Trott) #307418204a7492c] - test: add an indicatorisIBMi(Xu Meng) #30714ed7dd93b62] - test: use arrow functions in async-hooks tests (garygsc) #30137b802d5126b] - test: fix test-benchmark-streams (Rich Trott) #30757489d3334dc] - test: correct header length subtraction (Rich Trott) #30712e3c9e08185] - test: remove unused callback argument (Rich Trott) #30712ce11088a7d] - test: simplify forEach() usage (Rich Trott) #30712804e6e45b8] - test: remove unused callback argument (Rich Trott) #307125ea10a7e7b] - test: increase coverage for trace_events.js (Rich Trott) #30705c4c59121cd] - test: refactor createHook test (Jeny) #30568d6c211daee] - test: port worker + buffer test to N-API (Anna Henningsen) #30551a2f3f60241] - test: move test-https-server-consumed-timeout to parallel (Rich Trott) #30677e0bfa43953] - test: remove unnecessary common.platformTimeout() call (Rich Trott) #306779d4a854f33] - test: do not skip test-http-server-consumed-timeout (Rich Trott) #30677a596a5d11d] - test: remove unused function argument from http test (Rich Trott) #30677d191accd13] - test: add logging in case of infinite loop (Rich Trott) #3064995dd55011c] - test: remove destructuring from test-inspector-contexts (Rich Trott) #3064939c5f94ae3] - test: check for session.post() errors in test-insepctor-context (Rich Trott) #3064923ad927b66] - test: add mustCall() to test-inspector-contexts (Rich Trott) #30649cac77dd292] - test: add regression test for signal handler removal in exit (Anna Henningsen) #305895fd943a1d4] - test: move test-worker-prof to sequential (Rich Trott) #30628c5e3816505] - test: dir class initialisation w/o handler (Dmitriy Kikinskiy) #30313aad324dfcd] - test: change object assign by spread operator (poutch) #304388a63ea1db7] - test: use useful message argument in test function (Rich Trott) #30618c50e4f9dae] - test: test for minimum ICU version consistency (Richard Lau) #306082244479fc7] - test: code&learn var to let update (Nazar Malyy) #304368a0d1cb19c] - test: change object assign to spread object (poutch) #30422eead42470b] - test: use spread instead of Object.assign (dnlup) #304190b47d82cc1] - test: changed var to let in module-errors (Jamar Torres) #304136c7e491805] - test: use spread instead of object.assign (Shubham Chaturvedi) #30412b22a946f3c] - test: replace var with let in pre_execution.js (Vladimir Adamic) #30411a628fdcf38] - test: change var to let in test-trace-events (Jon Church) #3040669b1e688b8] - test: dns utils replace var (Osmond van Hemert) #3040599770a0b22] - test: test cover cases when trace is empty (telenord) #303112f32456084] - test: switch to object spread in common/benchmark.js (palmires) #30309c2a5da1e31] - test: add common.mustCall() to stream test (Rich Trott) #305614dd0f5ade5] - test: move explanatory comment to expected location in file (Rich Trott) #30561b38740d3b9] - test: move stream test to parallel (Rich Trott) #3056133de2c6799] - test: remove string literal as message in strictEqual() in stream test (Rich Trott) #30561dd07ad45e5] - test: use arrow function for callback in stream test (Rich Trott) #305610ce9a9caae] - test: replace setTimeout with setImmediate in stream test (Rich Trott) #3056144411217fa] - test: refactor test-dgram-multicast-set-interface-lo.js (Taylor Gagne) #30536aaee981b8e] - test: move test not requiring internet from internet to parallel (Rich Trott) #305457f3aec7e41] - test: use reserved .invalid TLD for invalid address in test (Rich Trott) #3054536b6b052d3] - test: improve assertion message in internet dgram test (Rich Trott) #30545a8e40a902b] - test: add test for options validation of createServer (ZYSzys) #305412bcd3a689f] - test: clean up http-set-trailers (Denys Otrishko) #30522376ec0128c] - test: handle undefined default_configuration (Shelley Vohr) #3046534b136bd76] - test: Change from var to const (Jure Stepisnik) #304316defe54379] - test: changed var to let in test-repl-editor (JL Phillips) #304431f54cf5e34] - test: improve test-fs-open (Artem Maksimov) #30280881de0e219] - test: change var to let (nathias) #304442eec51ab97] - test: changed var to const in test (Kerry Mahne) #30434fe8c46a924] - test: var to const in test-repl-multiline.js (SoulMonk) #30433b685d7ded2] - test: deflake test-http-dump-req-when-res-ends.js (Luigi Pinca) #303602b52a3f09f] - test: change var to const in parallel/test-stream-transform-final* (Kenza Houmani) #30448d2ab2bbb55] - test: replace Object.assign with object spread (Grigoriy Levanov) #30306deb1824ccf] - test: fix Python unittests in ./test and ./tools (cclauss) #303404f91459ee4] - test: mark test-http-dump-req-when-res-ends as flaky on windows (AshCripps) #303164acd3c3849] - test: fix test-benchmark-cluster (Rich Trott) #30342f6498d7a03] - test: deflake test-tls-close-notify.js (Luigi Pinca) #3020292c6fa4e16] - tls: allow empty subject even with altNames defined (Jason Macgowan) #2290658016e0232] - tls: change loop var to let (Xavier Redondo) #3044567e9985c16] - tls: replace var with let (Daniil Pletnev) #30308a3369b2fe2] - tls: replace var with let and const (Nolik) #3029962e7cf0121] - tls: refactor tls_wrap.cc (Artem Maksimov) #3030381712c93f3] - tools: enforce blank line between functions (Rich Trott) #3069627f7f89562] - tools: add unified plugin changing links for html docs (Marek Łabuz) #29946d9d6da4d53] - tools: enable more eslint rules (cjihrig) #30598701a1d5835] - tools: update ESLint to 6.7.1 (cjihrig) #3059847ee0be9bc] - tools: fix build at non-English windows (Rongjian Zhang) #30492ebaa738f41] - tools: make doctool work if no internet available (Richard Lau) #30214a209d41cd4] - tools: update certdata.txt (AshCripps) #30195051e27bf26] - tools: check-imports using utf-8 (cclauss) #30220dcbe376a59] - tty: truecolor check moved before 256 check (Duncan Healy) #304741413377bd3] - url: replace var with let in lib/url.js (xefimx) #30281a4c404cdac] - util: use let instead of var for util/inspect.js (Luciano) #3039998235d8c73] - util: replace var with let (Susana Ferreira) #304395342f5388e] - v8: mark serdes API as stable (Anna Henningsen) #302342b162a8462] - v8: inspect unserializable objects (Anna Henningsen) #30167