Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change var to const in parallel/test-stream-transform-final* #30448

Closed
wants to merge 1 commit into from
Closed

test: change var to const in parallel/test-stream-transform-final* #30448

wants to merge 1 commit into from

Conversation

khoumani
Copy link
Contributor

Change var to const in comments in parallel/test-stream-transform-final.js and parallel/test-stream-transform-final-sync.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2019
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR
Copy link
Member

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4041/

danbev pushed a commit that referenced this pull request Nov 15, 2019
@khoumani @danbev
test: change var to const in parallel/test-stream-transform-final*
86f0b75 
PR-URL: #30448
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danbev
Copy link
Contributor

danbev commented Nov 15, 2019

Landed in 86f0b75 🎉

@danbev danbev closed this Nov 15, 2019
@trivikr
Copy link
Member

trivikr commented Nov 17, 2019

The commit author isn't the same as PR author
I've requested @khoumani to update in their second PR #30440 (comment)

MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@khoumani @MylesBorins
test: change var to const in parallel/test-stream-transform-final*
72bbd5c 
PR-URL: #30448
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@khoumani @targos
test: change var to const in parallel/test-stream-transform-final*
2b52a3f 
PR-URL: #30448
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@khoumani @MylesBorins
test: change var to const in parallel/test-stream-transform-final*
2e6b3be 
PR-URL: #30448
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devnexen devnexen devnexen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@khoumani @BridgeAR @danbev @trivikr @jasnell @cjihrig @gengjiawen @devnexen @gireeshpunathil @nodejs-github-bot