-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: move test-https-server-consumed-timeout to parallel
Change the test to be robust in slow environments and move to parallel. The previous version of the test failed for me in parallel with just two or four simultaneous versions running. This version passes 96 simultaneous versions running, but still fails as designed if the request writes fail to prevent the request timeout from occurring. PR-URL: #30677 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
- Loading branch information
Showing
2 changed files
with
86 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
|
||
const assert = require('assert'); | ||
const http = require('http'); | ||
|
||
const durationBetweenIntervals = []; | ||
let timeoutTooShort = false; | ||
const TIMEOUT = common.platformTimeout(200); | ||
const INTERVAL = Math.floor(TIMEOUT / 8); | ||
|
||
runTest(TIMEOUT); | ||
|
||
function runTest(timeoutDuration) { | ||
let intervalWasInvoked = false; | ||
let newTimeoutDuration = 0; | ||
const closeCallback = (err) => { | ||
assert.ifError(err); | ||
if (newTimeoutDuration) { | ||
runTest(newTimeoutDuration); | ||
} | ||
}; | ||
|
||
const server = http.createServer((req, res) => { | ||
server.close(common.mustCall(closeCallback)); | ||
|
||
res.writeHead(200); | ||
res.flushHeaders(); | ||
|
||
req.setTimeout(timeoutDuration, () => { | ||
if (!intervalWasInvoked) { | ||
// Interval wasn't invoked, probably because the machine is busy with | ||
// other things. Try again with a longer timeout. | ||
newTimeoutDuration = timeoutDuration * 2; | ||
console.error('The interval was not invoked.'); | ||
console.error(`Trying w/ timeout of ${newTimeoutDuration}.`); | ||
return; | ||
} | ||
|
||
if (timeoutTooShort) { | ||
intervalWasInvoked = false; | ||
timeoutTooShort = false; | ||
newTimeoutDuration = | ||
Math.max(...durationBetweenIntervals, timeoutDuration) * 2; | ||
console.error(`Time between intervals: ${durationBetweenIntervals}`); | ||
console.error(`Trying w/ timeout of ${newTimeoutDuration}`); | ||
return; | ||
} | ||
|
||
assert.fail('Request timeout should not fire'); | ||
}); | ||
|
||
req.resume(); | ||
req.once('end', () => { | ||
res.end(); | ||
}); | ||
}); | ||
|
||
server.listen(0, common.mustCall(() => { | ||
const req = http.request({ | ||
port: server.address().port, | ||
method: 'POST' | ||
}, () => { | ||
let lastIntervalTimestamp = Date.now(); | ||
const interval = setInterval(() => { | ||
const lastDuration = Date.now() - lastIntervalTimestamp; | ||
durationBetweenIntervals.push(lastDuration); | ||
lastIntervalTimestamp = Date.now(); | ||
if (lastDuration > timeoutDuration / 2) { | ||
// The interval is supposed to be about 1/8 of the timeout duration. | ||
// If it's running so infrequently that it's greater than 1/2 the | ||
// timeout duration, then run the test again with a longer timeout. | ||
timeoutTooShort = true; | ||
} | ||
intervalWasInvoked = true; | ||
req.write('a'); | ||
}, INTERVAL); | ||
setTimeout(() => { | ||
clearInterval(interval); | ||
req.end(); | ||
}, timeoutDuration); | ||
}); | ||
req.write('.'); | ||
})); | ||
} |
This file was deleted.
Oops, something went wrong.