Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: createRequire can take import.meta.url directly #30495

Closed
wants to merge 1 commit into from
Closed

doc: createRequire can take import.meta.url directly #30495

wants to merge 1 commit into from

Conversation

GeoffreyBooth
Copy link
Member

@GeoffreyBooth GeoffreyBooth commented Nov 15, 2019 •
edited
Loading

This PR updates the createRequire example in https://nodejs.org/api/esm.html#esm_commonjs_json_and_native_modules to follow the new createRequire behavior, as opposed to the deprecated createRequireFromPath behavior. cc @MylesBorins

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 15, 2019
MylesBorins
MylesBorins approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MylesBorins
Copy link
Contributor

Can we please fast-track

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 15, 2019
@MylesBorins
Copy link
Contributor

Landed in 79126fc

MylesBorins pushed a commit that referenced this pull request Nov 16, 2019
@GeoffreyBooth @MylesBorins
doc: createRequire can take import.meta.url directly
79126fc 
PR-URL: #30495
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@GeoffreyBooth GeoffreyBooth deleted the fix-create-require-example branch November 16, 2019 19:23
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@GeoffreyBooth @MylesBorins
doc: createRequire can take import.meta.url directly
7e603be 
PR-URL: #30495
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@GeoffreyBooth @targos
doc: createRequire can take import.meta.url directly
9d6c293 
PR-URL: #30495
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@GeoffreyBooth @MylesBorins
doc: createRequire can take import.meta.url directly
25c8a13 
PR-URL: #30495
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeoffreyBooth @MylesBorins @guybedford @nodejs-github-bot