Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Use let instead of var for util/inspect.js #30399

Closed
wants to merge 3 commits into from
Closed

util: Use let instead of var for util/inspect.js #30399

wants to merge 3 commits into from

Conversation

lmammino
Copy link
Contributor

Style changes: use let instead of var in lib/internal/util/inspect.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 12, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4056/

@lmammino
Copy link
Contributor Author

Ci seems to be failing because the first letter (after subsystem) in my commit message is uppercase. I'll try to fix this with an amend commit...

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26616/

@gireeshpunathil
Copy link
Member

Linux-containered (ubuntu1804_sharedlibs_debug_x64): https://ci.nodejs.org/job/node-test-commit-linux-containered/16157/

@lmammino
Copy link
Contributor Author

Still seeing some failures in the CI, can someone guide me on what's wrong and how to resolve any pending issue?

@gireeshpunathil
Copy link
Member

last run (linux-containerized) was aborted due to infra issues. new run:
https://ci.nodejs.org/job/node-test-commit-linux-containered/16165/

@gireeshpunathil
Copy link
Member

once again: https://ci.nodejs.org/job/node-test-commit-linux-containered/16217/

@gireeshpunathil
Copy link
Member

the linux-containerized failure parallel/test-domain-error-types is known as in #30498

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
@lmammino @gireeshpunathil
util: use let instead of var for util/inspect.js
3f59704 
PR-URL: #30399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 3f59704.

thanks for the contribution!

@lmammino
Copy link
Contributor Author

Thank you all for helping me with this :)

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@lmammino @addaleax
util: use let instead of var for util/inspect.js
18e9b56 
PR-URL: #30399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
@lmammino @targos
util: use let instead of var for util/inspect.js
a4c404c 
PR-URL: #30399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lmammino @MylesBorins
util: use let instead of var for util/inspect.js
7421cc8 
PR-URL: #30399
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lmammino @BridgeAR @nodejs-github-bot @gireeshpunathil @jasnell @cjihrig @trivikr