Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object.assign -> object spread in several tests #30306

Closed
wants to merge 10 commits into from
Closed

Object.assign -> object spread in several tests #30306

wants to merge 10 commits into from

Conversation

glevanov
Copy link

@glevanov glevanov commented Nov 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Grigoriy Levanov added 9 commits November 6, 2019 16:45
url: replace Object.assign with object spread
3046aa7 
Replaces Object.assign with spread where object is simply cloned
util: replace Object.assign with object spread
1e3d014 
Replaces Object.assign with spread where object is simply cloned
url: fix linter warnings
8e40d02
util: fix linter warnings
65a1dad
test: replace Object.assign with object spread
3776cb6 
Replaces Object.assign with spread where object is simply cloned
test: replace Object.assign with object spread
bd7b1c1 
Replaces Object.assign with spread where object is simply cloned
test: replace Object.assign with object spread
7cfb619 
Replaces Object.assign with spread where object is simply cloned
test: replace Object.assign with object spread
f201ccd 
Replaces Object.assign with spread where object is simply cloned
test: replace Object.assign with object spread
afbc5d3 
Replaces Object.assign with spread where object is simply cloned
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
test: fix object spread for inline objects
621e12f 
Removes spread for inline objects - same can be achieved by discarding
object literal
@ChALkeR ChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2019
@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26441/

trivikr pushed a commit that referenced this pull request Nov 13, 2019
@trivikr
test: replace Object.assign with object spread
35ec010 
Replaces Object.assign with spread where object is simply cloned

PR-URL: #30306
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@trivikr
Copy link
Member

trivikr commented Nov 13, 2019

Landed in 35ec010

@glevanov Congratulations on your first commit in Node.js core! 🎉

@trivikr trivikr closed this Nov 13, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@MylesBorins
test: replace Object.assign with object spread
cd82e4d 
Replaces Object.assign with spread where object is simply cloned

PR-URL: #30306
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@targos
test: replace Object.assign with object spread
d2ab2bb 
Replaces Object.assign with spread where object is simply cloned

PR-URL: #30306
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@MylesBorins
test: replace Object.assign with object spread
aaedc06 
Replaces Object.assign with spread where object is simply cloned

PR-URL: #30306
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@glevanov @nodejs-github-bot @trivikr @ChALkeR @jasnell @addaleax @lpinca @cjihrig @gireeshpunathil @BridgeAR