Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise REPL uncaught exception text #30729

Merged
merged 1 commit into from
Dec 2, 2019
Merged

doc: revise REPL uncaught exception text #30729

merged 1 commit into from
Dec 2, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 30, 2019

Simplify the text about uncaught exceptions in the REPL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Nov 30, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
@Trott
doc: revise REPL uncaught exception text
b419d28 
Simplify the text about uncaught exceptions in the REPL.

PR-URL: nodejs#30729
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

Landed in b419d28

@Trott Trott merged commit b419d28 into nodejs:master Dec 2, 2019
@Trott Trott deleted the replrepl branch December 2, 2019 06:00
targos pushed a commit that referenced this pull request Dec 2, 2019
@Trott @targos
doc: revise REPL uncaught exception text
19b31c1 
Simplify the text about uncaught exceptions in the REPL.

PR-URL: #30729
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@Trott @targos
doc: revise REPL uncaught exception text
d7f1b0c 
Simplify the text about uncaught exceptions in the REPL.

PR-URL: #30729
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott @MylesBorins
doc: revise REPL uncaught exception text
043163a 
Simplify the text about uncaught exceptions in the REPL.

PR-URL: #30729
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
@Trott @BethGriggs
doc: revise REPL uncaught exception text
616927f 
Simplify the text about uncaught exceptions in the REPL.

PR-URL: #30729
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@targos targos targos approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @antsmartian @targos @gireeshpunathil @BethGriggs @trivikr @nodejs-github-bot