Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,doc: fix broken links #30662

Closed
wants to merge 1 commit into from
Closed

src,doc: fix broken links #30662

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 26, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 26, 2019
@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 26, 2019
@richardlau richardlau mentioned this pull request Nov 28, 2019
Closed
3 tasks
cjihrig added a commit that referenced this pull request Nov 28, 2019
@cjihrig
src,doc: fix broken links
8792c3f 
PR-URL: #30662
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 28, 2019

Landed in 8792c3f.

@cjihrig cjihrig closed this Nov 28, 2019
@cjihrig cjihrig deleted the link branch November 28, 2019 15:31
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@cjihrig @addaleax
src,doc: fix broken links
9d8d2e1 
PR-URL: #30662
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
@cjihrig @targos
src,doc: fix broken links
9de7196 
PR-URL: #30662
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig @MylesBorins
src,doc: fix broken links
f6360c1 
PR-URL: #30662
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @lpinca @devnexen @richardlau @trivikr @nodejs-github-bot