[v12.x] Backport update to V8 7.8 #30109

targos · 2019-10-25T07:10:38Z

Backport of #29694

Two things left to do (please help if you can):

API/ABI compat patch for the new changes in 7.8. See diff in header files
Fix conflict in 9f06e03

addaleax · 2019-10-25T22:57:35Z

I’ve pushed changes for the merge conflict and some ABI-compat changes. The Node.js tests pass, but I don’t know how to best run the V8 tests locally (./configure && make test-v8 doesn’t work for me on a clean checkout of this branch).

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2583/

Also, the TracedGlobal changes look like they’re going to be the trickiest by far.

nodejs-github-bot · 2019-10-25T23:00:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26200/

nodejs-github-bot · 2019-10-26T12:16:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26203/

addaleax · 2019-10-26T13:42:56Z

Ok, so here’s the remaining header diff: https://gist.github.com/addaleax/15afba086636bad8af3b846074464b89

I’m not sure that we have to be concerned about the TickSample removal and the TracedGlobal/EmbedderHeapTracer changes … the latter feature isn’t used by us, and I don’t think it would make sense to use it for addons that aren’t in control of the Isolate.

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2585/

nodejs-github-bot · 2019-10-26T13:43:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26207/

addaleax · 2019-10-26T17:33:25Z

New V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2586/

addaleax · 2019-10-26T18:51:33Z

Looks like there’s something wrong with the snapshot generation and I’m not really sure how to proceed … @targos this feels a bit familiar, do you remember something?

targos · 2019-10-27T09:24:56Z

@addaleax in that case I don't know. Sometimes PPC fails on a new V8 release because a patch needs to be backported, but we didn't have this problem with the original 7.8 PR.
It's possible that one of the changes that you reverted got ported to PPC afterwards and we also need to revert the port.

addaleax · 2019-10-27T10:14:22Z

It's possible that one of the changes that you reverted got ported to PPC afterwards and we also need to revert the port.

I don’t see how any of these would affect something platform-specific…

Here’s a V8 CI for this, without my changes: https://ci.nodejs.org/job/node-test-commit-v8-linux/2589/

mhdawson · 2019-11-01T16:09:36Z

@sam-github I think the PPC failures are likely related the python issue you are working on right?

targos · 2019-12-04T13:58:23Z

Rebased and cleaned up the commit log. Let's see how CI goes!

nodejs-github-bot · 2019-12-04T13:59:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27329/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2676/

nodejs-github-bot · 2019-12-05T13:47:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27352/

targos · 2019-12-05T14:00:26Z

@nodejs/platform-aix @nodejs/platform-ppc do you see what could be causing the failures on IBM platforms?

targos · 2019-12-05T14:41:55Z

Plinux run without the compatibility patches: https://ci.nodejs.org/view/All/job/node-test-commit-plinux/29462/

PR-URL: #30109 Reviewed-By: Myles Borins <[email protected]>

Backport-PR-URL: #30109 PR-URL: #28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. [email protected],[email protected],[email protected] CC=[email protected] Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Michael Starzinger <[email protected]> Commit-Queue: Tamer Tas <[email protected]> Cr-Commit-Position: refs/heads/master@{#59045} Refs: v8/v8@bd019bd Backport-PR-URL: #30109 PR-URL: #26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Backport-PR-URL: #30109 PR-URL: #26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Fixes a compilation issue on some platforms Backport-PR-URL: #30109 PR-URL: #27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

This should be semver-patch since actual invocation is version conditional. Backport-PR-URL: #30109 PR-URL: #27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

`std::atomic_init<size_t>` is not implemented on all platforms. Backport-PR-URL: #30109 PR-URL: #27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html Backport-PR-URL: #30109 PR-URL: #28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

Backport-PR-URL: #30109 PR-URL: #27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Backport-PR-URL: #30109 PR-URL: #28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

until c6196ad7a2d601a4e1fdb313bfe2ec727fd67f7a Co-authored-by: Ujjwal Sharma <[email protected]> Co-authored-by: Michaël Zasso <[email protected]> Backport-PR-URL: #30109 PR-URL: #29694 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>

Backport-PR-URL: #30109 PR-URL: #29694 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>

Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. Backport-PR-URL: #30109 PR-URL: #29694 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>

Original commit message: [debugger] Fix code coverage for break/return inside switch-case Case statements have a list of statements associated with them, but are not blocks, and were hence not fixed-up correctly for code coverage. This CL also applies the fix-up to the "body" of case statements, in this way removing ranges reported as uncovered between the final break/return in a case and the next case (or end of function). Drive-by: Add optional pretty printing to code coverage test results. Change-Id: I5f4002d4e17b7253ed516d99f7c389ab2264be10 Bug: v8:9705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798426 Reviewed-by: Toon Verwaest <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Commit-Queue: Sigurd Schneider <[email protected]> Cr-Commit-Position: refs/heads/master@{#63719} Refs: v8/v8@deac757 Backport-PR-URL: #30109 PR-URL: #29626 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Original commit message: Make code generator python3.7 compatible (async keyword). Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109 Fixes: #29548 Refs: - #29548 (comment) - #29520 - #29340 - https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351 - https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a Backport-PR-URL: #30109 PR-URL: #29585 Refs: #29520 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Original commit message: [build] Add message-template.h to build file This was missed during a file move and can cause build bugs. Bug: chromium:991547 Change-Id: I157e7bb656956c08293c205c0d00884aecc7adee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798430 Commit-Queue: Sigurd Schneider <[email protected]> Reviewed-by: Sigurd Schneider <[email protected]> Auto-Submit: Peter Marshall <[email protected]> Cr-Commit-Position: refs/heads/master@{#63711} Refs: v8/v8@716875d Backport-PR-URL: #30109 PR-URL: #29694 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>

Original commit message: [regexp] Fix the order of named captures on the groups object Named capture properties on the groups object should be ordered by the capture index (and not alpha-sorted). This was accidentally broken in https://crrev.com/c/1687413. Bug: v8:9822,v8:9423 Change-Id: Iac6f866f077a1b7ce557ba47e8ba5d7e7014b3ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864829 Auto-Submit: Jakob Gruber <[email protected]> Reviewed-by: Peter Marshall <[email protected]> Commit-Queue: Peter Marshall <[email protected]> Cr-Commit-Position: refs/heads/master@{#64306} Refs: v8/v8@ed40ab1 Fixes: #29878 Backport-PR-URL: #30109 PR-URL: #30064 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

Original commit message: [api] Fix handle leak when getting Context embedder data The `Context::SlowGetAlignedPointerFromEmbedderData()` method returns a pointer, so the fact that it allocates handles is not obvious to the caller. Since this is the slow path anyway, simply add a handle scope inside of it. The tests are also modified to perform the same check for the `Object` equivalent of this method. Change-Id: I5f03c9a7b70b3a17315609df021606a53c9feb2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879902 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#64583} Refs: v8/v8@e5dbc95 Fixes: #30127 Backport-PR-URL: #30109 PR-URL: #30130 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Original commit message: PPC: Using a scratch register under LoadRealStackLimit Change-Id: Id9e9142a8ff185309b91dcfff70dae8ccf8b5166 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954244 Reviewed-by: Junliang Yan <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#65357} Refs: v8/v8@0a05508 PR-URL: #30109 Reviewed-By: Myles Borins <[email protected]>

Original commit message: [postmortem] Load files using utf-8 to support Python 3 Change-Id: I174d38cc33210c07d1a7596627e1b2d21bb06313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895560 Reviewed-by: Mathias Bynens <[email protected]> Commit-Queue: Michaël Zasso <[email protected]> Cr-Commit-Position: refs/heads/master@{#64717} Refs: v8/v8@a7dffcd Backport-PR-URL: #30109 PR-URL: #30218 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

This commit updates V8's postmortem metadata generation script to support V8 7.8. The following metadata has changed: - v8dbg_class_JSDate__value__Object - The postmortem metadata generation script needed to be updated. No action should be required by postmortem tools. - v8dbg_class_JSRegExp__source__Object - The postmortem metadata generation script needed to be updated. No action should be required by postmortem tools. Backport-PR-URL: #30109 PR-URL: #29694 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>

Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #30109 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>

Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 Backport-PR-URL: #29241 PR-URL: #28955

Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <[email protected]>

deps: revert 2ac8bb719 from upstream V8 Original commit message: profiler: Allow querying SnapshotObjectId for native objects - Adds regular native heap entries to the HeapObjectsMap. - Adds a side map for keeping a mapping of native objects to their canonical heap entry that they have been merged into. Change-Id: Ida00628126ded1948ceb2a0cbe14da817af7f361 Bug: chromium:988350 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1720810 Commit-Queue: Michael Lippautz <[email protected]> Reviewed-by: Alexei Filippov <[email protected]> Reviewed-by: Ulan Degenbaev <[email protected]> Cr-Commit-Position: refs/heads/master@{#63140} Refs: v8/v8@2ac8bb7 [The `SuppressMicrotaskExecutionScope` hack only works because the constructor that allows specifying an alternative microtask queue was never actually implemented.] deps: revert fb698cec37 from upstream V8 Original commit message: [isolate-data] Move hot fields closer to isolate_root In generated code, we access fields inside IsolateData through the root-register. On some platforms it is significantly cheaper to access things that are close to the root-register value than things that are located far away. The motivation for this CL was a 5% difference in Octane/Mandreel scores between // Part of the stack check. cmpq rsp,[r13+0x9ea8] and cmpq rsp,[r13-0x30] // Mandreel score improved by 5%. This moves the StackGuard up to fix Mandreel. As a drive-by, also move two more fields up that are accessed by each CallCFunction. Tbr: [email protected] Bug: v8:9534,chromium:993264 Change-Id: I5418b63d40274a138e285fa3c99b96e33a814fb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751345 Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Yang Guo <[email protected]> Auto-Submit: Jakob Gruber <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#63187} Refs: v8/v8@fb698ce src: re-add flags removed in V8 7.8 as no-ops PR-URL: #30109 Reviewed-By: Myles Borins <[email protected]>

Notable changes: New assert APIs The `assert` module now provides experimental `assert.match()` and `assert.doesNotMatch()` methods. They will validate that the first argument is a string and matches (or does not match) the provided regular expression This is an experimental feature. Ruben Bridgewater [#30929](#30929). Advanced serialization for IPC The `child_process` and `cluster` modules now support a `serialization` option to change the serialization mechanism used for IPC. The option can have one of two values: * `'json'` (default): `JSON.stringify()` and `JSON.parse()` are used. This is how message serialization was done before. * `'advanced'`: The serialization API of the `v8` module is used. It is based on the HTML structured clone algorithm. and is able to serialize more built-in JavaScript object types, such as `BigInt`, `Map`, `Set` etc. as well as circular data structures. Anna Henningsen [#30162](#30162). CLI flags The new `--trace-exit` CLI flag makes Node.js print a stack trace whenever the Node.js environment is exited proactively (i.e. by invoking the `process.exit()` function or pressing Ctrl+C). legendecas [#30516](#30516). ___ The new `--trace-uncaught` CLI flag makes Node.js print a stack trace at the time of throwing uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This option is not enabled by default because it may affect garbage collection behavior negatively. Anna Henningsen [#30025](#30025). ___ The `--disallow-code-generation-from-strings` V8 CLI flag is now whitelisted in the `NODE_OPTIONS` environment variable. Shelley Vohr [#30094](#30094). New crypto APIs For DSA and ECDSA, a new signature encoding is now supported in addition to the existing one (DER). The `verify` and `sign` methods accept a `dsaEncoding` option, which can have one of two values: * `'der'` (default): DER-encoded ASN.1 signature structure encoding `(r, s)`. * `'ieee-p1363'`: Signature format `r || s` as proposed in IEEE-P1363. Tobias Nießen [#29292](#29292). ___ A new method was added to `Hash`: `Hash.prototype.copy`. It makes it possible to clone the internal state of a `Hash` object into a new `Hash` object, allowing to compute the digest between updates. Ben Noordhuis [#29910](#29910). Dependency updates libuv was updated to 1.34.0. This includes fixes to `uv_fs_copyfile()` and `uv_interface_addresses()` and adds two new functions: `uv_sleep()` and `uv_fs_mkstemp()`. Colin Ihrig [#30783](#30783). ___ V8 was updated to 7.8.279.23. This includes performance improvements to object destructuring, RegExp match failures and WebAssembly startup time. The official release notes are available at https://v8.dev/blog/v8-release-78. Michaël Zasso [#30109](#30109). New EventEmitter APIs The new `EventEmitter.on` static method allows to async iterate over events. Matteo Collina [#27994](#27994). ___ It is now possible to monitor `'error'` events on an `EventEmitter` without consuming the emitted error by installing a listener using the symbol `EventEmitter.errorMonitor`. Gerhard Stoebich [#30932](#30932). ___ Using `async` functions with event handlers is problematic, because it can lead to an unhandled rejection in case of a thrown exception. The experimental `captureRejections` option in the `EventEmitter` constructor or the global setting change this behavior, installing a `.then(undefined, handler)` handler on the `Promise`. This handler routes the exception asynchronously to the `Symbol.for('nodejs.rejection')` method if there is one, or to the `'error'` event handler if there is none. Setting `EventEmitter.captureRejections = true` will change the default for all new instances of `EventEmitter`. This is an experimental feature. Matteo Collina [#27867](#27867). Performance Hooks are no longer experimental The `perf_hooks` module is now considered a stable API. legendecas [#31101](#31101). Introduction of experimental WebAssembly System Interface (WASI) support A new core module, `wasi`, is introduced to provide an implementation of the [WebAssembly System Interface](https://wasi.dev/) specification. WASI gives sandboxed WebAssembly applications access to the underlying operating system via a collection of POSIX-like functions. This is an experimental feature. Colin Ihrig [#30258](#30258). PR-URL: #31691

targos added semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency. v12.x labels Oct 25, 2019

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 25, 2019

targos mentioned this pull request Oct 25, 2019

N-API: memory leak with call to napi_create_function #28988

Closed

This was referenced Oct 25, 2019

Node.js 12 - V8 version roadmap #25082

Closed

proposal moves forward to stage 3 \o/ tc39/proposal-optional-chaining#107

Merged

mhofman mentioned this pull request Oct 25, 2019

src: implement v8 host weakref hooks #29874

Merged

3 tasks

addaleax force-pushed the v8-7.8-v12.x branch from 0f6a15d to 1955d8f Compare October 26, 2019 17:16

targos mentioned this pull request Nov 8, 2019

deps: V8: cherry-pick 53e62af #29898

Closed

targos force-pushed the v12.x-staging branch from a0974d6 to bcd2238 Compare November 11, 2019 09:57

alangpierce mentioned this pull request Nov 12, 2019

Implement optional chaining and nullish coalescing alangpierce/sucrase#461

Closed

targos force-pushed the v8-7.8-v12.x branch from 1955d8f to 501000b Compare December 4, 2019 13:57

targos force-pushed the v8-7.8-v12.x branch 2 times, most recently from b48295f to 000d83b Compare December 5, 2019 13:46

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020

deps: update V8 to 7.8.279.23

35f2892

PR-URL: #30109 Reviewed-By: Myles Borins <[email protected]>

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020

build: reset embedder string to "-node.0"

a91ed2e

PR-URL: #30109 Reviewed-By: Myles Borins <[email protected]>

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020

deps: patch V8 to be API/ABI compatible with 7.4 (from 7.7)

b335529

Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <[email protected]>

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

targos deleted the v8-7.8-v12.x branch October 17, 2020 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v12.x] Backport update to V8 7.8 #30109

[v12.x] Backport update to V8 7.8 #30109

targos commented Oct 25, 2019 •

edited

Loading

addaleax commented Oct 25, 2019 •

edited

Loading

nodejs-github-bot commented Oct 25, 2019

nodejs-github-bot commented Oct 26, 2019

addaleax commented Oct 26, 2019

nodejs-github-bot commented Oct 26, 2019

addaleax commented Oct 26, 2019

addaleax commented Oct 26, 2019

targos commented Oct 27, 2019

addaleax commented Oct 27, 2019

mhdawson commented Nov 1, 2019

targos commented Dec 4, 2019

nodejs-github-bot commented Dec 4, 2019 •

edited by targos

Loading

nodejs-github-bot commented Dec 5, 2019

targos commented Dec 5, 2019

targos commented Dec 5, 2019

[v12.x] Backport update to V8 7.8 #30109

[v12.x] Backport update to V8 7.8 #30109

Conversation

targos commented Oct 25, 2019 • edited Loading

addaleax commented Oct 25, 2019 • edited Loading

nodejs-github-bot commented Oct 25, 2019

nodejs-github-bot commented Oct 26, 2019

addaleax commented Oct 26, 2019

nodejs-github-bot commented Oct 26, 2019

addaleax commented Oct 26, 2019

addaleax commented Oct 26, 2019

targos commented Oct 27, 2019

addaleax commented Oct 27, 2019

mhdawson commented Nov 1, 2019

targos commented Dec 4, 2019

nodejs-github-bot commented Dec 4, 2019 • edited by targos Loading

nodejs-github-bot commented Dec 5, 2019

targos commented Dec 5, 2019

targos commented Dec 5, 2019

targos commented Oct 25, 2019 •

edited

Loading

addaleax commented Oct 25, 2019 •

edited

Loading

nodejs-github-bot commented Dec 4, 2019 •

edited by targos

Loading