New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add author credit to zipcode counting notebook, fix cudf string processing argument #11

Open

isVoid wants to merge 547 commits into branch-0.16 from fix/notebook_credit

Owner

isVoid commented Jun 26, 2023

Description

This PR fixes the usage of a small cudf string processing method. regex should be set to false for .str.split without
regex delimiter. In addition, adds credit to authors.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

isVoid and others added 30 commits

October 3, 2022 21:43


          unwrap_pyoptcol is missing except keyword that causes exceptions …

c676c3d

…ignored, fixes function bug (rapidsai#719)

Fixes a bug in the cdef function when `pyoptcol` is `None` and gets mishandled (raised as error). This error is captured in one of the pytests for `point_linestring_distance`. However, due to the cdef function is missing the `except` keyword, the exception gets ignored by the python interpreter and not reraised.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#719


          Merge pull request rapidsai#720 from rapidsai/branch-22.10

a1d225c

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci]


          Memory_usage method for GeoSeries/GeoDataFrame and GeoDataFrame ref…

849231b

…actor. (rapidsai#604)

This PR adds the memory_usage for the large, complex `GeoSeries` object, and tests for `GeoSeries` and `GeoDataframe`

This also includes a `GeoDataFrame` refactor that makes it possible for `cudf` to call `memory_usage` through `GeoDataFrame.super()` and works toward better integration with `cudf`.

Closes rapidsai#714

Authors:
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: rapidsai#604


          Merge pull request rapidsai#723 from rapidsai/branch-22.10

91b9ef0

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci]


          Update link to c++ developer guide (rapidsai#718)

0ba3e84

This PR moves the library wide overview section to top level `developer guide`. And updates link to c++ developer guide. As of creation, the link to c++ developer guide is not published yet. Should verify before merge.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#718


          Merge pull request rapidsai#724 from rapidsai/branch-22.10

d53abf6

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci]


          Auto-add new Issues and PRs to cuspatial's project (rapidsai#618)

0e0c7f3

The new project boards should have every issue/PR within them. This workflow makes the addition of the issues/PRs automatic rather than the current manual process.

Authors:
  - Ben Jarmak (https://github.com/jarmak-nv)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)
  - Mark Sadang (https://github.com/msadang)

URL: rapidsai#618


          Merge pull request rapidsai#727 from rapidsai/branch-22.10

4e4b07f

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci]


          Fix error in users.ipynb (rapidsai#726)

22f4c43

After @isVoid fixed the bug that produced an error cell in `users.ipynb` it doesn't seem to be updating automatically - it is probably rendering the notebook, not executing it.

This PR updates the notebook with the removed bug.

Authors:
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#726


          Merge pull request rapidsai#728 from rapidsai/branch-22.10

0be470a

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci]


          Remove cudf/cuda.cuh Dependency (rapidsai#729)

4bd17de

Currently cuspatial does not depend on anything defined in `cudf/detail/utility/cuda.cuh`, removing stale dependency.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#729


          Add header only cuspatial::quadtree_on_points (rapidsai#639)

37d3db5

Closes rapidsai#566.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Michael Wang (https://github.com/isVoid)

URL: rapidsai#639


          Merge pull request rapidsai#732 from rapidsai/branch-22.10

c4b1440

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci]


          update changelog

f9044a9


          Merge branch 'branch-22.10' into branch-22.12-merge-22.10

0028afe


          Merge pull request rapidsai#740 from harrism/branch-22.12-merge-22.10

81d4394

Fix failed automerge (branch 22.12 merge 22.10)


          Introduce multipoint_range interface; Refactors point_distance AP…

930a2f3

…I to support multipoint to multipoint distance. (rapidsai#731)

closes rapidsai#704

Contributes to rapidsai#703 

This PR introduces `Multipoint_range` interface, and simplifies the API of `point_distance`. Also updates the `point_distance` to support multipoint-multipoint distance.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#731


          Header-only trajectory_bounding_boxes (rapidsai#741)

ca31988

Contributes to rapidsai#563 

Header-only refactoring of `cuspatial::trajectory_bounding_boxes`

Note the commit list is messy because it was originally based off of rapidsai#628 which was merged into 22.10.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Paul Taylor (https://github.com/trxcllnt)

URL: rapidsai#741


          Remove stale labeler (rapidsai#751)

This PR removes the stale issue labeler workflow

Authors:
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#751


          Add python bindings for (multi)point-(multi)point distance (rapidsai#734

cf5117b

)

This PR adds python bindings to Point-point distance. Depend on rapidsai#731 
Reverts change to comment: rapidsai#731 (comment)

Close rapidsai#578

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#734


          Update Conda Recipe and README.md (rapidsai#730)

ef27758

This PR bumps cudatoolkit version in conda recipe to 11.5 (and removes old versions). Updates `README.md` to reflect recent changes and verified build steps from bare metal.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#730


          Introduce multilinestring_range structure, simplifies point-linestr…

928b6ea

…ing distance API (rapidsai#747)

Follow up to rapidsai#731 , this PR introduces a new range object named `multilinestring_range` and simplifies the point-linestring distance API. Closes rapidsai#705 .

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#747


          Augment Cuspatial Test Utility to Allow User Specified Abs Error (rap…

92c3a08

…idsai#752)

This PR augments Cuspatial Vector Equality Test Utility with an extra parameter to allow user pass in pre-defined absolute error.
In many cases, cuspatial has to compare results with external libraries such as shapely or gdal. Since cuspatial allows user to pick computation precision based on input data (not a bug!), requiring the result to match external libraries within 4ULP is often too stringent, as external libraries often perform computation in different precisions. Adding the flexibility to specifiy abs error in test utilitiy makes it easy for developer to pick desired error range based on specific use cases.

This PR also introduces a test macro that shows lineno of failed tests.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#752


          Replacing markdown issue templates with yml forms (rapidsai#748)

1f17152

This PR replaces the existing markdown issue templates with [form-based YML templates](https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/). They provide a more interactive experience and can require certain fields be filled out prior to issue submission.

Authors:
  - Ben Jarmak (https://github.com/jarmak-nv)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#748


          Force using old fmt in nvbench. (rapidsai#783)

aab7d86

This is a port of rapidsai/cudf#12067. 

Original post:
> The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#783


          Delete deprecated board GitHub Actions (rapidsai#779)

e17d969

The `new-issues-to-triage-project.yml` Action automatically adds issues to a few different classic GitHub boards that we're no longer using. 

This PR deletes the now-unnecessary action.

Authors:
  - Ben Jarmak (https://github.com/jarmak-nv)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#779


          Introduce ULP Based Floating Point Equality Test to Device Function (r…

8702bc6

…apidsai#773)

This PR adds `float_eq_by_ulp` utility to allow practical near equality for floating point computation in device code.

In GIS application, near equal is often required due to rounding error of floating point and may wrong categorization of line collinearity or point on line test.

Using this test does not incur visible performance degradation:
```
$ python ~/scratch/nvbench/scripts/nvbench_compare.py naive.json ulp.json 
['naive.json', 'ulp.json']
# floating_point_equivalence_benchmark

## [0] Tesla V100-SXM2-32GB

|  FloatingPointType  |  NumFloats  |   Ref Time |   Ref Noise |   Cmp Time |   Cmp Noise |      Diff |   %Diff |  Status  |
|---------------------|-------------|------------|-------------|------------|-------------|-----------|---------|----------|
|         F32         |   100000    |   2.617 us |      55.95% |   2.478 us |      53.16% | -0.139 us |  -5.30% |   PASS   |
|         F32         |   1000000   |   2.508 us |      59.48% |   2.471 us |      53.17% | -0.037 us |  -1.49% |   PASS   |
|         F32         |  10000000   |   2.509 us |      58.42% |   2.553 us |      52.45% |  0.044 us |   1.76% |   PASS   |
|         F32         |  100000000  |   2.612 us |      56.19% |   2.483 us |      55.23% | -0.129 us |  -4.94% |   PASS   |
|         F64         |   100000    |   2.501 us |      72.35% |   2.483 us |      54.59% | -0.018 us |  -0.72% |   PASS   |
|         F64         |   1000000   |   2.514 us |      60.63% |   2.564 us |      55.11% |  0.050 us |   1.98% |   PASS   |
|         F64         |  10000000   |   2.609 us |      56.87% |   2.492 us |      56.80% | -0.117 us |  -4.48% |   PASS   |
|         F64         |  100000000  |   2.519 us |      61.38% |   2.495 us |      57.26% | -0.025 us |  -0.98% |   PASS   |
```

Note that the run time is very small in time scale so the result is very noisy. The average time difference is very small though.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#773


          Refactor of pairwise_linestring_distance to use `multilinestring_ra…

870f103

…nge`, adds support to multilinestring distance (rapidsai#755)

Note, this is the first part of `pairwise_linestring_distance` refactoring, part 1 of PR: rapidsai#753

Depends on rapidsai#752 

Contributes to rapidsai#706, rapidsai#703

Closes rapidsai#745

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#755


          address issue with vector equivalent utility (rapidsai#777)

48fbedf

Closes rapidsai#772 , Address various issue with vector equivalent utility.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#777


          Header-only refactoring of trajectory_distances_and_speeds (rapidsai#769

0c2fe86

)

Closes rapidsai#563 

In addition to refactoring to header-only API, this PR changes the implementation to use `thrust_transform` (two input version) instead of `thrust::adjacent_difference`. This simplifies the code a bit and eliminates the need for the `duplicate_first_element_iterator`, which was a bit confusing.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: rapidsai#769

GPUtester and others added 30 commits

May 31, 2023 09:08


          Merge pull request rapidsai#1159 from rapidsai/branch-23.06

085d946

Forward-merge branch-23.06 to branch-23.08


          Add Benchmark to pairwise_linestring_polygon_distance (rapidsai#1153)

f571e9d

This PR adds nvbenchmark suite benchmarks to pariwise_linestring_polygon distance. This PR also adds `multilinestring_array_generator` and reuses in both linestring distance and linestring-polygon distance.

The addition of `multilinestring_array_generator` completes the `geometry_generator.cuh`, which now has generators for `multipolygons`, `multilinestrings` and `multipoints`.

I have an additional driver python suite that helps parameterizing this nvbench test suite. Not sure where to put them for now.
https://gist.github.com/isVoid/99ce3f6425528217da78118ab2653959

Contributes to rapidsai#259 
Closes rapidsai#1160

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1153


          Merge pull request rapidsai#1163 from rapidsai/branch-23.06

361bd4d

Forward-merge branch-23.06 to branch-23.08


          Add multilinestring_segment_manager for segment related methods in …

50e3b6a

…multilinestring ranges (rapidsai#1134)

closes rapidsai#1055

This PR adds `multilinestring_segment_manager` owning class to track the lifetime of intermediate allocations that has to do with segment iterators. In addition `multilinestring_segment_range` is added as the non-owning class to the previous class to provide iterators to the segments. The syntax to use this object is like:

```c++
auto segment_manager = multilinestrings._segments(stream);
auto segment_range = segment_manager.range();
```
Then a user can easily access the segments in the multilinestrings with:
```c++
for (auto seg : segment_range) {
    auto length = sqrt(dot(seg.a, seg.b));
}
```

Secondly, this PR includes tests that has empty geometry collections in the input, linestring_polygon_distance now correctly computes nans for these input pairs.

In addition, `CUSPATIAL_EXPECTS_VALID_MULTI*_SIZES` is relaxed. Valid polygon and ring sizes are only implicitly required but not checked via the size of the arrays since they are insufficient checks. Accordingly, some tests are also relaxed.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1134


          Merge pull request rapidsai#1167 from rapidsai/branch-23.06

40d00f7

Forward-merge branch-23.06 to branch-23.08


          Add documentation for pairwise_linestring_polygon_distance, `pairwi…

400cc15

…se_polygon_distance` (rapidsai#1145)

closes rapidsai#1146

Add missing API examples for 23.06 release.

 - Added example for `pairwise_linestring_polygon_distance`, `pairwise_polygon_distance`

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Ben Jarmak (https://github.com/jarmak-nv)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#1145


          Run docs nightly (rapidsai#1141)

f07ac48

This PR configures `cuspatial` docs builds to also run nightly (not just on PR merges only)

Authors:
  - Jake Awe (https://github.com/AyodeAwe)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1141


          Merge pull request rapidsai#1168 from rapidsai/branch-23.06

1a0593d

Forward-merge branch-23.06 to branch-23.08


          cuSpatial pip packages (rapidsai#1148)

4b76c44

Initial draft PR to build statically linked cuspatial wheels.

Closes rapidsai#869.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)
  - Mark Harris (https://github.com/harrism)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#1148


          Remove documentation build scripts for Jenkins (rapidsai#1169)

9f990ea

We recently created new scripts for building documentation with GitHub Actions.

This PR removes the old scripts that were used by Jenkins and are no longer in use.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1169


          Merge branch-23.06 into branch-23.08

ddf831d


          more 23.06 -> 23.08

663ac38


          pyproject.toml not pyproject.py

d428850


          handle yaml anchors

e9a227d


          Merge pull request rapidsai#1175 from trxcllnt/branch-23.08-merge-23.06

39f66d0

Fix branch-23.06 forward-merge into branch-23.08


          update changelog

73d3c3e


          Merge pull request rapidsai#1184 from rapidsai/branch-23.06

cb4e28b

Forward-merge branch-23.06 to branch-23.08


          Fix update version (rapidsai#1187)

34dc2a3

Updates `update-version.sh` to follow the pattern from rapidsai/cugraph#3638

Required for `23.06` because `python/cuspatial/pyproject.py` does not exist thus breaking the script. This means any hotfixes to this version will have issues during release.

Also updates a version in `cpp/doxygen/Doxyfile` which was outdated.

Skipped CI since this script is not tested by CI.

Authors:
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - AJ Schmidt (https://github.com/ajschmidt8)


          Merge branch-23.06 into rbanch-23.08

00fc842


          Merge pull request rapidsai#1190 from raydouglass/branch-23.08-merge-…

0c395d1

…23.06

Forward merge `branch-23.06` into `branch-23.08`


          use rapids-upload-docs script (rapidsai#1181)

400b310

This PR updates the `build_docs.sh` script to use the new consolidatory `rapids-upload-script` [shared script](rapidsai/gha-tools#56). 

The shared script enables docs uploads to applicable S3 buckets for branch. nightly and PR builds.

Authors:
  - Jake Awe (https://github.com/AyodeAwe)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#1181


          Better support for binary predicates with large inputs. (rapidsai#1166)

1d2c174

Closes rapidsai#1142 

This PR adds a few bugfixes and optimizations that improve performance when large `GeoSeries` are used with binary predicates. It also corrects a few errors in the predicate logic that were revealed when the size of the feature space increased by combining all possible features in the `dispatch_list`.

Changes:
`contains.py`
- Add `pairwise_point_in_polygon` and steps to resemble `quadtree` results.

`contains_geometry_processor.py`
- Drop `is True` and add a TODO for future optimization.

`feature_contains.py`
- Refactor `_compute_polygon_linestring_contains` to handle `GeoSeries` containing `LineStrings` of varying lengths.

`feature_contains_properly.py`
- Add `pairwise_point_in_polygon` as default mode with documentation.
- Add `PointMultiPointContains` which is needed by internal methods.

`feature_crosses.py`
- Drop extraneous `intersection`

`feature_disjoint.py`
- Add `PointPointDisjoint` and drop extraneous `intersections`.

`feature_equals.py`
- Fix LineStringLineStringEquals which wasn't properly handling LineStrings with varying lengths.

`feature_intersects.py`
- Drop extraneous `intersection`

`feature_touches.py`
- Fix LineStringLineStringTouches. It is slow and needs further optimization.
- Fix PolygonPolygonTouches. It is also slow and needs further optimization.

`geoseries.py`
- Drop index from `input_types`.
- Fix `point_indices` for `Point` type.
- Optimize `reset_index` which was doing a host->device copy.

`binpred_test_dispatch.py`
- Add test case
`test_binpred_large_examples.py`
- Test large sets of all the dispatched tests together.

`test_equals_only_binpreds.py`
- Test corrections to input_types indexes.

`test_binpred_large_examples.py`
- Use the features from `test_dispatch` to create large `GeoSeries` and compare results with `GeoPandas`.

`test_feature_groups.py`
- Test each of the `dispatch_list` feature sets combined into a single GeoSeries.

`binpred_utils.py`
- Don't count hits when point and polygon indexes don't match (a bug in `_basic_contains_count`).
- Optimize mask generation in `_points_and_lines_to_multipoints`

`column_utils.py`
- Optimize `contains_only` calls.

Authors:
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Michael Wang (https://github.com/isVoid)

URL: rapidsai#1166


          External issue triage GHA (rapidsai#1177)

77ca81b

closes rapidsai#1176 

This PR:
- Removes the https://github.com/rapidsai/cuspatial/labels/Needs%20Triage label from the issue templates
- Adds in a GHA that automatically adds the label, and comments automatically when an issue is filed from someone outside the team.

~TODO:
Before we merge, we need to remove the `? -` from the https://github.com/rapidsai/cuspatial/labels/Needs%20Triage label, it breaks some integrations we have.~ DONE

Authors:
  - Ben Jarmak (https://github.com/jarmak-nv)
  - Mark Harris (https://github.com/harrism)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1177


          Remove osmnx dependency and use a small local dataset (rapidsai#1195)

72edee1

close rapidsai#1194
This PR removes `osmnx` dependency and instead use a small locally hosted dataset.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#1195


          Update to CMake 3.26.4 (rapidsai#1196)

56fa0c2

Updates minimum required CMake version to 3.26.4

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#1196


          Remove Stale Demo Scripts (rapidsai#1180)

f43d18b

This PR removes scripts under `python/cuspatial/cuspatial/demo`. This decision is made mainly due to:
1. The scripts are outdated, most of them are using deprecated python APIs.
2. The scripts only demonstrates a single use of cuspatial API, not an end-to-end use case. These demos are sufficiently covered by `user_guide` at the moment. And is not worth converting into notebooks.

Closes rapidsai#209 
Closes rapidsai#312 
Closes rapidsai#341 
Closes rapidsai#885

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1180


          Updates Build Instructions to Adjust for Devcontainer Instructions an…

9d91cd3

…d Remove Stale Infomation (rapidsai#1179)

closes rapidsai#1174 

Minor improvement:

- updates build development environment to point to devcontainers, not rapids-compose.
- Move point-linestring python test to correct location.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Ben Jarmak (https://github.com/jarmak-nv)
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1179


          Fix a small typo in pairwise_linestring_distance (rapidsai#1199)

bb6c7cb

This PR fixes a small typo in pairwise_linestring_distance

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: rapidsai#1199


          Simplify point-in-polygon header only APIs (rapidsai#1192)

d5499d2

closes rapidsai#707 

This PR simplifies `point_in_polygon` and `pairwise_point_in_polygon` API using `multipoint_range` and `multipolygon_range`. While these range methods supports a pair of multi geometry semantics, in this PR I'm not really targeting to create an API that works with multipoint-in-multipolygon semantics (such as "any point in any polygon", or "all points in any polygon", that sort of semantics). Therefore, this PR introduces `contains_only_single_geometry` method in `multipoint_range` and `multipolygon_range` that provides compile-time check for API that only want to work single-type geometry ranges. There are caveats to this introduction, see *caveats* section below.

This refactor results in a net decrease in LOC, and the compatibility layer for `is_point_in_polygon` is removed. The API dries up to a point where there's no raw kernel anymore.

In addition, previous `pairwise_point_in_polygon` API stores the row wise result in an int32_t per pair. Since it's only storing booleans, this PR uses `uint8_t` instead. This saves memory and increases throughputs.

### Caveats
`contains_only_single_geometry` method is an over-constrained method comparing to what it's really testing. A multipoint range can have a materialized column of integer sequences and still represent a single geometry column. The reason behind this refactor is that the original point-in-polygon test explicitly requires (by the number of arguments) that only single geometry columns accepted by the API. This means developers know at compile time that the geometry used in the API are constructed this way. `contains_only_single_geometry` is a `constexpr` method and verifies developers construction at compile time as well. This maintains the developer expectation while allowing `multi*_range` to be retrofit into the modern APIs.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#1192


          fix cudf string split, add credits

86ccb5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet