Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Remove external web service dependency in notebooks #1194

Closed
isVoid opened this issue Jun 8, 2023 · 0 comments · Fixed by #1195
Closed

[BUG]: Remove external web service dependency in notebooks #1194

isVoid opened this issue Jun 8, 2023 · 0 comments · Fixed by #1195
Assignees
@isVoid
Labels
bug Something isn't working

Comments

@isVoid
Copy link
Contributor

isVoid commented Jun 8, 2023

Version

23.08

On which installation method(s) does this occur?

Rapids-Compose

Describe the issue

In branch-23.06 we introduced osmnx dependency to cuspatial-api-examples. While it's a very useful package to grep osm dataset in example, it depends on web services that are often unstable and may fail when called repeatedly from the same host. Since notebook are tested in CI, we should remove this dependency.

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response
@isVoid isVoid added the bug Something isn't working label Jun 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Jun 8, 2023
@isVoid isVoid mentioned this issue Jun 8, 2023
Merged
3 tasks
@isVoid isVoid moved this from Todo to Review in cuSpatial Jun 8, 2023
@isVoid isVoid self-assigned this Jun 9, 2023
@rapids-bot rapids-bot bot closed this as completed in #1195 Jun 9, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 9, 2023
@isVoid
Remove osmnx dependency and use a small local dataset (#1195)
72edee1 
close #1194
This PR removes `osmnx` dependency and instead use a small locally hosted dataset.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1195
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isVoid isVoid

Labels
bug Something isn't working
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove osmnx dependency and use a small local dataset isVoid/cuspatial
1 participant
@isVoid