Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] demo tests contain deprecated functions #312

Closed
Salonijain27 opened this issue Oct 20, 2020 · 7 comments · Fixed by #1180
Closed

[BUG] demo tests contain deprecated functions #312

Salonijain27 opened this issue Oct 20, 2020 · 7 comments · Fixed by #1180
Labels
bug Something isn't working Needs Triage Need team to review and classify

Comments

@Salonijain27
Copy link
Contributor

The demo tests contain functions that have been deprecated from cuspatial. Therefore, the tests do not run
@Salonijain27 Salonijain27 added Needs Triage Need team to review and classify bug Something isn't working labels Oct 20, 2020
@harrism
Copy link
Member

harrism commented Oct 20, 2020

What are the "demo tests"? Can you provide a link?

@zhangjianting
Copy link
Contributor

Python demo code is under python/cuspatial/demos. They were mostly developed last summer and are outdated. Some of these demos can not run out-of-box anyway as they rely on external data. I would suggest remove these demo code as they are not essential to cuspatial as a library.

Alternatively, I am thinking the suitability of creating a new repo outside of cuspatial to host demo codes for apps using both public or private data for performance test. In this way, demo/app code (using C++/Python/Java APIs) does not need to go through code review process by cuspatial team. This may attract more contributors who are more users (including some researchers) rather than developers, or those who do not have sufficient knowledge of cuda/cudf to develop production level code and make direct contributions to cuspatial. As a first step, when I get a chance, I will refactorize some of these outdated demo code and put them on my personal github repo as a new project.

@harrism
Copy link
Member

harrism commented Oct 22, 2020

I recommend just putting such notebooks in https://github.com/rapidsai-community/notebooks-contrib

@thomcom
Copy link
Contributor

thomcom commented Jan 13, 2021

@Salonijain27 are you referring to the code snippets in python/cuspatial/demos? If so, I agree with Jianting that we should remove them.

@thomcom
Copy link
Contributor

thomcom commented Jan 14, 2021

@taureandyernv is talking about creating notebooks from these. Lets delete them and move on with the notebooks work.

@taureandyernv taureandyernv mentioned this issue Jan 16, 2021
Closed
4 tasks
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@github-actions github-actions bot added the stale label Feb 16, 2021
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@jarmak-nv jarmak-nv moved this to Todo in cuSpatial Nov 3, 2022
@harrism harrism mentioned this issue Feb 22, 2023
Closed
@isVoid isVoid mentioned this issue Jun 6, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Jun 12, 2023
@isVoid
Remove Stale Demo Scripts (#1180)
f43d18b 
This PR removes scripts under `python/cuspatial/cuspatial/demo`. This decision is made mainly due to:
1. The scripts are outdated, most of them are using deprecated python APIs.
2. The scripts only demonstrates a single use of cuspatial API, not an end-to-end use case. These demos are sufficiently covered by `user_guide` at the moment. And is not worth converting into notebooks.

Closes #209 
Closes #312 
Closes #341 
Closes #885

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1180
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Needs Triage Need team to review and classify
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Stale Demo Scripts isVoid/cuspatial
5 participants
@thomcom @harrism @zhangjianting @Salonijain27 @jarmak-nv