Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Stale Demo Scripts #1180

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Remove Stale Demo Scripts #1180

merged 2 commits into from
Jun 12, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jun 6, 2023 •
edited
Loading

Description

This PR removes scripts under python/cuspatial/cuspatial/demo. This decision is made mainly due to:

  1. The scripts are outdated, most of them are using deprecated python APIs.
  2. The scripts only demonstrates a single use of cuspatial API, not an end-to-end use case. These demos are sufficiently covered by user_guide at the moment. And is not worth converting into notebooks.

Closes #209
Closes #312
Closes #341
Closes #885

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner June 6, 2023 18:22
@isVoid isVoid requested review from trxcllnt and harrism June 6, 2023 18:22
@github-actions github-actions bot added the Python Related to Python code label Jun 6, 2023
@isVoid isVoid added tech debt Related to improving software quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2023
@isVoid
Copy link
Contributor Author

isVoid commented Jun 7, 2023

Looks like the new osmnx package returns 502 when querying OSM:

Exception: Server returned:
<Response [502]> Bad Gateway
<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx</center>
</body>
</html>

Trying to rerun once and see if this is an one-off issue.

@isVoid
Copy link
Contributor Author

isVoid commented Jun 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit f43d18b into rapidsai:branch-23.08 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code tech debt Related to improving software quality
Projects
cuSpatial
Status: Todo
Milestone
No milestone
2 participants
@isVoid @harrism