Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Benchmark to pairwise_linestring_polygon_distance #1153

Merged
merged 11 commits into from
May 31, 2023
Merged

Add Benchmark to pairwise_linestring_polygon_distance #1153

merged 11 commits into from
May 31, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented May 25, 2023 •
edited
Loading

Description

This PR adds nvbenchmark suite benchmarks to pariwise_linestring_polygon distance. This PR also adds multilinestring_array_generator and reuses in both linestring distance and linestring-polygon distance.

The addition of multilinestring_array_generator completes the geometry_generator.cuh, which now has generators for multipolygons, multilinestrings and multipoints.

I have an additional driver python suite that helps parameterizing this nvbench test suite. Not sure where to put them for now.
https://gist.github.com/isVoid/99ce3f6425528217da78118ab2653959

Contributes to #259
Closes #1160

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels May 25, 2023
@isVoid
update pairwise_linestring_distance to allow parameterizing number of…
62c645a 
… pairs and number of linestring per multilinestring separately
@isVoid isVoid added benchmarks Related to benchmarks feature request New feature or request non-breaking Non-breaking change labels May 25, 2023
@isVoid isVoid marked this pull request as ready for review May 30, 2023 19:51
@isVoid isVoid requested review from a team as code owners May 30, 2023 19:51
harrism
harrism approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the walking angle.

cpp/include/cuspatial_test/geometry_generator.cuh Outdated Show resolved Hide resolved
@isVoid isVoid self-assigned this May 31, 2023
@isVoid isVoid linked an issue May 31, 2023 that may be closed by this pull request
[FEA]: Benchmark suite for linestring-polygon distance #1160
Closed
@isVoid
Copy link
Contributor Author

isVoid commented May 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit f571e9d into rapidsai:branch-23.06 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
benchmarks Related to benchmarks cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Benchmark suite for linestring-polygon distance
2 participants
@isVoid @harrism