Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address issue with vector equivalent utility #777

Merged
merged 4 commits into from
Nov 8, 2022
Merged

address issue with vector equivalent utility #777

merged 4 commits into from
Nov 8, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 3, 2022

Description

Closes #772 , Address various issue with vector equivalent utility.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner November 3, 2022 19:22
@isVoid isVoid self-assigned this Nov 3, 2022
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Nov 3, 2022
@isVoid isVoid requested review from thomcom and harrism and removed request for zhangjianting and jrhemstad November 3, 2022 19:26
@isVoid isVoid added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change bug Something isn't working labels Nov 3, 2022
@thomcom
Copy link
Contributor

thomcom commented Nov 4, 2022

This needs passing tests.

@isVoid
Copy link
Contributor Author

isVoid commented Nov 5, 2022

Ok I think it's fixed.

@isVoid
Copy link
Contributor Author

isVoid commented Nov 7, 2022

rerun tests

1 similar comment
@isVoid
Copy link
Contributor Author

isVoid commented Nov 7, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Nov 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 48fbedf into rapidsai:branch-22.12 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Issues with expect_vector_equivalent test utility
3 participants
@isVoid @thomcom @harrism