Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap_pyoptcol is missing except keyword that causes exceptions ignored, fixes function bug #719

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 3, 2022

Description

Fixes a bug in the cdef function when pyoptcol is None and gets mishandled (raised as error). This error is captured in one of the pytests for point_linestring_distance. However, due to the cdef function is missing the except keyword, the exception gets ignored by the python interpreter and not reraised.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner October 3, 2022 20:34
@isVoid isVoid requested a review from thomcom October 3, 2022 20:34
@github-actions github-actions bot added the Python Related to Python code label Oct 3, 2022
@isVoid isVoid added non-breaking Non-breaking change bug Something isn't working labels Oct 3, 2022
@isVoid isVoid requested a review from harrism October 3, 2022 20:39
@isVoid
Copy link
Contributor Author

isVoid commented Oct 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c676c3d into rapidsai:branch-22.10 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants