Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC]: Build Instruction Contains Information about a Removed Module #1174

Closed
isVoid opened this issue Jun 5, 2023 · 0 comments · Fixed by #1179
Closed

[DOC]: Build Instruction Contains Information about a Removed Module #1174

isVoid opened this issue Jun 5, 2023 · 0 comments · Fixed by #1179
Assignees
@isVoid
Labels
doc Documentation tech debt Related to improving software quality

Comments

@isVoid
Copy link
Contributor

isVoid commented Jun 5, 2023 •
edited
Loading

How would you describe the priority of this documentation request

Medium

Is this for new documentation, or an update to existing docs?

Update

Describe the incorrect/future/missing documentation

In the last section of build instruction, it mentions that some test targets includes external data. The example it uses is the shapefile reader, which is removed in 23.04. The documentation should not mention about this target.

In addition, we should verify if there is still any test that still uses external data. If not we should remove test_fixture folder. (Can always reintroduce in the future if a better shapefile reader makes its return).

If this is a correction, please provide a link to the incorrect documentation. If this is a new documentation request, please link to where you have looked.

https://docs.rapids.ai/api/cuspatial/stable/developer_guide/build/
@isVoid isVoid added doc Documentation Needs Triage Need team to review and classify labels Jun 5, 2023
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Jun 5, 2023
@isVoid isVoid added tech debt Related to improving software quality and removed Needs Triage Need team to review and classify labels Jun 5, 2023
@isVoid isVoid mentioned this issue Jun 6, 2023
Merged
3 tasks
@jarmak-nv jarmak-nv moved this from Todo to In Progress in cuSpatial Jun 7, 2023
@isVoid isVoid self-assigned this Jun 9, 2023
@isVoid isVoid moved this from In Progress to Review in cuSpatial Jun 9, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 20, 2023
@isVoid
Updates Build Instructions to Adjust for Devcontainer Instructions an…
9d91cd3 
…d Remove Stale Infomation (#1179)

closes #1174 

Minor improvement:

- updates build development environment to point to devcontainers, not rapids-compose.
- Move point-linestring python test to correct location.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Ben Jarmak (https://github.com/jarmak-nv)
  - Mark Harris (https://github.com/harrism)

URL: #1179
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isVoid isVoid

Labels
doc Documentation tech debt Related to improving software quality
Projects
cuSpatial
Status: Done
Milestone
No milestone
1 participant
@isVoid