Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf/cuda.cuh Dependency #729

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Remove cudf/cuda.cuh Dependency #729

merged 1 commit into from
Oct 5, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 5, 2022

Description

Currently cuspatial does not depend on anything defined in cudf/detail/utility/cuda.cuh, removing stale dependency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 5, 2022
@isVoid isVoid self-assigned this Oct 5, 2022
@isVoid isVoid requested a review from a team as a code owner October 5, 2022 00:56
@isVoid isVoid requested review from trxcllnt and jrhemstad October 5, 2022 00:56
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Oct 5, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Oct 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4bd17de into rapidsai:branch-22.12 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isVoid @thomcom @harrism