Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element picker/zapper don't work if cosmetic filtering is disabled #3212

Closed
cy7yz2rj opened this issue Nov 9, 2017 · 4 comments
Closed

Element picker/zapper don't work if cosmetic filtering is disabled #3212

cy7yz2rj opened this issue Nov 9, 2017 · 4 comments

Comments

@cy7yz2rj
Copy link

cy7yz2rj commented Nov 9, 2017

Describe the issue

Disabling cosmetic filtering by default will prevent the element picker and zapper from manifesting, when called from either toolbar icon or context menu.

Verified by creating new profile, changing the add-on signature requirement in about:config, installing uBO and toggling the cosmetic filtering setting. No further changes from default Firefox or uBO configuration.

One or more specific URLs where the issue occurs

https://github.com/gorhill/uBlock/releases

Steps for anyone to reproduce the issue

  1. Open uBO dashboard
  2. Under Settings pane, check "Disable cosmetic filtering "
  3. Element picker/zapper no longer usable.

Your settings

  • OS/version: Debian 9.2 (stable)
  • Browser/version: Firefox ESR (52.4.0)
  • uBlock Origin version: 1.14.17 and newer
@gorhill
Copy link
Owner

gorhill commented Nov 9, 2017 •
edited
Loading

Duplicate of #2963.

@gorhill gorhill closed this as completed Nov 9, 2017
@gorhill gorhill reopened this Feb 21, 2018
@gorhill gorhill removed the duplicate label Feb 21, 2018
@gorhill
Copy link
Owner

gorhill commented Feb 21, 2018 •
edited
Loading

My mistake, this is not a duplicate.

@gorhill gorhill mentioned this issue Feb 21, 2018
Closed
@uBlock-user
Copy link
Contributor

I can reproduce it in Chromium 66 too.

@MetroidCatcher
Copy link

The element picker for me does not working at all. Just tested it on a fresh Firefox profile, installed uBlock and it's not working.

@uBlock-user uBlock-user mentioned this issue Apr 30, 2018
Closed
8 tasks
@gorhill gorhill mentioned this issue May 16, 2018
Closed
8 tasks
@uBlock-user uBlock-user mentioned this issue Jun 22, 2018
Closed
8 tasks
@uBlock-user uBlock-user mentioned this issue Aug 15, 2018
Closed
8 tasks
@yourduskquibbles yourduskquibbles mentioned this issue Oct 9, 2018
Closed
8 tasks
@gwarser gwarser mentioned this issue Oct 9, 2018
Closed
8 tasks
@uBlock-user uBlock-user mentioned this issue Nov 1, 2018
Closed
8 tasks
@gorhill gorhill mentioned this issue Mar 24, 2019
Closed
5 tasks
@gorhill gorhill changed the title Element picker/zapper don't work if cosmetic filtering is disabled (Firefox 52 ESR / uBO 1.14.17+) Element picker/zapper don't work if cosmetic filtering is disabled Mar 24, 2019
gorhill referenced this issue Sep 21, 2019
@gorhill
Add support for elemhide (through specifichide)
23c4c80 
Related documentation:
- https://help.eyeo.com/en/adblockplus/how-to-write-filters#element-hiding

Related feedback/discussion:
- https://www.reddit.com/r/uBlockOrigin/comments/d6vxzj/

The `elemhide` filter option as per ABP semantic is
now supported. Previously uBO would consider `elemhide`
to be an alias of `generichide`.

The support of `elemhide` is through the convenient
conversion of `elemhide` option into existing
`generichide` option and new `specifichide` option.

The purpose of the new `specifichide` filter option
is to disable all specific cosmetic filters, i.e.
those who target a specific site.

Additionally, for convenience purpose, the filter
options `generichide`, `specifichide` and `elemhide`
can be aliased using the shorter forms `ghide`,
`shide` and `ehide` respectively.
@uBlock-user uBlock-user mentioned this issue Sep 23, 2019
Closed
@uBlock-user uBlock-user mentioned this issue Dec 14, 2019
Closed
8 tasks
This was referenced Feb 8, 2020
Closed
Closed
@uBlock-user uBlock-user mentioned this issue May 4, 2020
Closed
@uBlock-user uBlock-user mentioned this issue Feb 5, 2021
Closed
8 tasks
@perks perks mentioned this issue Feb 16, 2021
Closed
8 tasks
@uBlock-user uBlock-user mentioned this issue Apr 28, 2021
Closed
8 tasks
gorhill added a commit that referenced this issue Jul 12, 2021
@gorhill
Disable creation of cosmetic filters in picker when unenforceable
e983f9a 
Related issue:
- #3212

The element picker will now properly work on sites where
cosmetic filtering is disabled, but will not allow the
creation of cosmetic filters when specific cosmetic filters
are not meant to be enforced in the current page.

When specific cosmetic filters are not meant to be enforced,
the element picker will still allow the creation of network
filters, that is unless the current page is trusted, in which
case using the element picker is pointless.
@gwarser gwarser mentioned this issue Jul 12, 2021
Closed
8 tasks
@gorhill gorhill closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gorhill @MetroidCatcher @uBlock-user @cy7yz2rj