Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling cosmetic filtering causes element picker to not work #1658

Closed
8 tasks done
ghost opened this issue Jul 12, 2021 · 2 comments
Closed
8 tasks done

disabling cosmetic filtering causes element picker to not work #1658

ghost opened this issue Jul 12, 2021 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@ghost
Copy link

ghost commented Jul 12, 2021

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

When I disable cosmetic filtering on some site by clicking on toolbar icon (click to disable cosmetic filtering on this site) then element picker button does not work, not entering element picker mode

A specific URL where the issue occurs

https://vukajlija.com/

Steps to Reproduce

  1. go to url
  2. disable cosmetic filtering on that site
  3. enter element picker mode (refreshing site may be needed before step 3)

Expected behavior

i expect to be able to select elements and see their id list and url list on bottom right corner

Actual behavior

it only works when cosmetic filtering enabled, otherwise nothing happens

uBlock Origin version

1.36.0

Browser name and version

Firefox 91

Operating System and version

Windows 10 21H1

@gwarser
Copy link

gwarser commented Jul 12, 2021

Duplicate of gorhill/uBlock#3212

Was fixed today gorhill/uBlock@e983f9a

@gwarser gwarser closed this as completed Jul 12, 2021
@gorhill
Copy link
Member

gorhill commented Jul 12, 2021

i expect to be able to select elements and see their id list

Even with the fix, you won't see "their id list" (assuming you refer to the list of suggested cosmetic filters), since it's pointless to create cosmetic filters for a site for which cosmetic filtering is disabled.

@uBlock-user uBlock-user added the duplicate This issue or pull request already exists label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants