Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker Mode does not work when Disable cosmetic filtering is enabled #1487

Closed
7 of 8 tasks
SulpherStaer opened this issue Feb 5, 2021 · 2 comments
Closed
7 of 8 tasks
Labels
duplicate This issue or pull request already exists

Comments

@SulpherStaer
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

The Element Picker mode does not function correctly when 'Disable cosmetic filtering' is enabled. It does not grey out the screen and enter element selection mode. Element Zapper, which as a user seems to perform a similar method of selecting an element, does still function.

A specific URL where the issue occurs

youtube.com
github.com

Steps to Reproduce

  1. In uBlock Origin Dashboard, under Default behavior, enable 'Disable cosmetic filtering'
  2. Go to any site (I personally tested on youtube & github.com
  3. Click the badge to open the quick menu
  4. Enter Element Picker Mode

Expected behavior:

I expect the website to 'gray out', and red selection boxes to appear to select particular elements.

Actual behavior:

The site did not grey out, and no red selection boxes appeared.

Your environment

  • uBlock Origin version: 1.32.4
  • Browser Name and version: Google Chrome 88.0.4324.150 (64bit)
  • Operating System and version: Windows 10 (Build 19041.746)
@uBlock-user
Copy link
Contributor

Duplicate of gorhill/uBlock#3212.

@uBlock-user uBlock-user added the duplicate This issue or pull request already exists label Feb 5, 2021
@SulpherStaer
Copy link
Author

Ah, yes. I did not check the old area when looking if this bug was already reported. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants