Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Zapper not working on YouTube (Cosmetic Filtering NOT disabled) #1500

Closed
8 tasks done
perks opened this issue Feb 16, 2021 · 28 comments
Closed
8 tasks done

Element Zapper not working on YouTube (Cosmetic Filtering NOT disabled) #1500

perks opened this issue Feb 16, 2021 · 28 comments
Labels
invalid not a uBlock issue

Comments

@perks
Copy link

perks commented Feb 16, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Similar issues to gorhill/uBlock#3212 , however this occurs even with cosmetic filtering NOT disabled (default, unmodified state). Occurs on Mac OS X Catalina on Chrome

A specific URL where the issue occurs

https://www.youtube.com
[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. Install stock UBO addon from chrome store
  2. Go to https://youtube.com
  3. Attempt do use the element zapper
  4. Nothing occurs

Expected behavior:

Filters properly loading and zapper element being able to be used on the website

Actual behavior:

UBO refuses to work/load the element zapper on youtube.com

Below is a screenshot of the process. Fresh install with default settings, does not work on YouTube but will work on all other sites (tested with github)
Ublock Bug

Your environment

  • uBlock Origin version: uBlock Origin v1.33.2
  • Browser Name and version: Google Chrome Version 88.0.4324.150 (Official Build) (x86_64)
  • Operating System and version: Mac OS X Catalina 10.15.7
@uBlock-user
Copy link
Contributor

Did you give uBO permission to run in incognito mode ?

@perks
Copy link
Author

perks commented Feb 16, 2021

@uBlock-user yes, you can see in the gif that it works on other sites (in incognito mode)

@liamengland1
Copy link

Any messages in uBo's console?

@perks
Copy link
Author

perks commented Feb 16, 2021

@llacb47 I have the logger open in the gif from start to finish in the gif recording, no messages it seems. I also have the web-developer tools console open while trying to activate the zapper and nothing. I don't know if there is any other console output I should be looking for

@uBlock-user uBlock-user added the something to address something to address label Feb 16, 2021
@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

The extension's own dev console might have something.

Enable "Developer mode" at chrome://extensions/?id=cjpalhdlnbpafiamejdnhcphjbkeiagm, then you should be able to click background.html link, which will open the dev console for uBO.

@perks
Copy link
Author

perks commented Feb 16, 2021

@gorhill I'm not seeing anything generated in the extension-specific console output. Is there a UI action I can do to trigger a logging event there to see if I am looking at the right thing? (Tested with loading page, trying to select zapper and picker tools)

edit: I also included Verbose logging in the filter to see if anything showed up, but didn't see anything

Screen Shot 2021-02-16 at 9 10 11 PM

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

I can't reproduce such issue. When you load the Youtube page, the logger output is anomalous in that it does not show any network requests being fired for Youtube, this is not normal, it's almost as if the browser does not notify uBO of the network events: the logger does not show any network events, the popup panel reports that nothing is being blocked.

@perks
Copy link
Author

perks commented Feb 16, 2021

@gorhill yes it is very strange I noticed that as well. If you have any other ideas on how to troubleshoot this I can give it a shot on my end.

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

I see 4 entries in the logger when you navigate to Youtube. One of them seems to be uBO fetching a filter list -- the initiator is cjpalhdlnbpafiamejdnhcphjbkeiagm.chrome-extension-scheme -- but quite coincidentally, this occurred right when you navigated to Youtube. Is this entry showing up every time or was it a coincidence?

@perks
Copy link
Author

perks commented Feb 16, 2021

That was a coincidence, I tried loading it a couple more times and you just get the default filters running against youtube
Screen Shot 2021-02-16 at 9 37 35 PM

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

When I navigate to Youtube I get the expected network events reported in the logger:

a

On your side I just see the scriptlet injection filters being reported, these are injected on a webNavigation event. The picker/zapper not launching indicate that there are no content scripts injected, and also weird is that there is no network activity reported.

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

Well, on my side I am testing using Chromium 87.0.4280.66, my distribution hasn't upgraded to 88.0.4324.150 yet.

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

In your GIF, I see uBO working properly once you navigated to github.com from youtube.com. Did you try to navigate to youtube.com from, say, github.com to see if this works?

@perks
Copy link
Author

perks commented Feb 16, 2021

@gorhill Interesting enough this same behavior seems to be replicated on all google-related domains. So anytime I visit a google domain it seems network request introspection by the extension is disabled.

I tried navigating to/from regular web pages with no observed changes

I thought this might be related to issues with "hosted" apps related to websites, but I do not have anything/have removed all apps from chrome://apps and restarted the browser and the behavior exists

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

If you open the dev tools of the page and bring forth the "Network" pane, does the browser's own dev tools logger report network events as would be expected for youtube.com?

b

@perks
Copy link
Author

perks commented Feb 16, 2021

Screen Shot 2021-02-16 at 10 04 52 PM

Seems devtools work fine

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

There is a difference from my side though, I see the main document being loaded from a service worker. I don't get this on my side.

If you close all Youtube tabs and go to chrome://serviceworker-internals/ and unregister workers related to youtube.com, do you still have the issue?

@perks
Copy link
Author

perks commented Feb 16, 2021

Really strange, everytime I try unregistering the service both through chrome://serviceworker-internals and the Application tab in devtools anytime I navigate within or reload the page the serviceworker gets re-registered and started

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

the serviceworker gets re-registered and started

That's normal. I actually get similar result as yours when I navigate to youtube.com while there is a worker registered, but in my case uBO can see and filter all the requests.

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

this same behavior seems to be replicated on all google-related domains

Are other blockers similarly affected? (AdGuard, ABP)

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

Could there be policies in your browser preventing uBO from working on Google-related domains? See chrome://policy/.

@perks
Copy link
Author

perks commented Feb 16, 2021

I do have chrome policies it seems, this must be it. I tried the other Adblock extensions and the behavior is almost identical (not all requests logged, unable to use "element picker"-esque functionality). Thank you for the help, unfortunately it seems that this is probably unresolvable if it is related to a specific chrome policy.

@liamengland1
Copy link

I do have chrome policies it seems, this must be it.

??? Just because you have a chrome policy isn't the reason, have you identified a specific policy that causes the issue or are you just speculating?

@gorhill
Copy link
Member

gorhill commented Feb 16, 2021

Do you know which policy is causing this behavior? If ever there are report sof such behavior in the future, it will be useful to know which policy to check.

@perks
Copy link
Author

perks commented Feb 16, 2021

@gorhill I am pretty sure it is utilizing the ExtensionSettings policy, blocked_permissions has various blacklisted permissions including debugger, etc which is probably responsible.

@perks
Copy link
Author

perks commented Feb 17, 2021

I do have chrome policies it seems, this must be it.

??? Just because you have a chrome policy isn't the reason, have you identified a specific policy that causes the issue or are you just speculating?

@llacb47 calm down, seeing as you've been 0 percent helpful in the conversation no need to ping me

closing as it seems the policy permission mapping fits, and behaviour is only produced when visting the domains listed in the runtime_block_hosts which is further confirmed for the description of that field here https://support.google.com/chrome/a/answer/9867568?p=Configure_ExtensionSettings_policy&visit_id=637491196329043895-531615411&rd=1#

@perks perks closed this as completed Feb 17, 2021
@liamengland1
Copy link

I didn't even ping you, but OK. Glad to see you identified the issue.

@gorhill
Copy link
Member

gorhill commented Feb 17, 2021

behaviour is only produced when visting the domains listed in the runtime_block_hosts

Thanks. I might try to experiment with this to find whether uBO can detect being prevented from doing it's job, and if so then maybe figure out a way to at least inform the user.

@uBlock-user uBlock-user added invalid not a uBlock issue and removed something to address something to address labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

4 participants