Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-picker does not come up on some pages #83

Closed
3 of 8 tasks
UnitedMarsupials-zz opened this issue Jun 22, 2018 · 5 comments
Closed
3 of 8 tasks

Element-picker does not come up on some pages #83

UnitedMarsupials-zz opened this issue Jun 22, 2018 · 5 comments
Labels
duplicate This issue or pull request already exists

Comments

@UnitedMarsupials-zz
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Element-picker does not come up on some pages

A specific URL where the issue occurs

Any of thehill.com's pages lately, for example this one.

Steps to Reproduce

  1. Open the page in Firefox
  2. Attempt to bring up uBlock's element-picker through the menu on the tool bar
  3. Attempt to bring uBlock's element-picker through the context menu

Expected behavior:

I expected my cursor to change to "cross" so I can pick the element I want hidden

Actual behavior:

Nothing happened.

Your environment

  • uBlock Origin version: uBlock Origin v1.16.10
  • Browser Name and version: Firefox 60.0.2 (64 bit)
  • Operating System and version: Windows 10
@gwarser gwarser added the unable to reproduce cannot reproduce the issue label Jun 22, 2018
@gwarser
Copy link

gwarser commented Jun 22, 2018

Any chance you have cosmetic filtering disabled on that page? https://github.com/gorhill/uBlock/wiki/Per-site-switches#no-cosmetic-filtering

@uBlock-user
Copy link
Contributor

Works fine on thehill.com

@uBlock-user
Copy link
Contributor

If you made any changes to about:config then undo them or undo all custom firefox settings to default and see it works again.

@UnitedMarsupials-zz
Copy link
Author

@gwarser , you are right! How embarrassing...

So, this has nothing to do with a particular site, just an interface-bug:

  • either the element-picker should be completely disabled in the GUI, when the cosmetic filtering is disabled
  • or, the element-picker should still come up to allow adding an element for blocking, even if no blocking takes place until cosmetic filtering is re-enabled

You, probably, already have an "issue" for this problem, don't you?

@uBlock-user
Copy link
Contributor

Duplicate of gorhill/uBlock#3212

@uBlock-user uBlock-user marked this as a duplicate of gorhill/uBlock#3212 Jun 22, 2018
@uBlock-user uBlock-user added duplicate This issue or pull request already exists and removed unable to reproduce cannot reproduce the issue labels Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants