Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block element on booking.com #1568

Closed
8 tasks done
thany opened this issue Apr 27, 2021 · 4 comments
Closed
8 tasks done

Block element on booking.com #1568

thany opened this issue Apr 27, 2021 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@thany
Copy link

thany commented Apr 27, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Element picker does not work on booking.com. When selecting it, absolutely nothing happens. And when I say nothing, I do really honestly genuinely mean nothing, as in not even so much as an error in the console. Just nothing.

On other websites -> Works
Javascript disabled -> Still not working
When uBlock Origin is the only extension after disabling all others and hitting F5 on the page -> Still not working
When in a new profile where uBlock Origin is the only extension -> This does work
When in a private window -> Doesn't work

There might be a problem in my settings, but then why would it work fine on other websites? Booking.com might be doing something crazy that it isn't doing when in a fresh profile (which is likely, they are known to do weird stuff on a per-user or per-visit basis). But then it should also work fine in a private window, which it doesn't.

Element zapper does work, in all these scenarios.

A specific URL where the issue occurs

https://www.booking.com/index.en-gb.html

Steps to Reproduce

  1. Open URL
  2. Right-click somewhere and select "Block element", or
  3. Click the uBlock icon in the toolbar and click the eyedropper button

Expected behavior:

It goes into element picker mode

Actual behavior:

Absolutely nothing.

Your environment

  • uBlock Origin version: 1.35.0
  • Browser Name and version: Firefox 88 x64
  • Operating System and version: Windows 10 20H2
@liamengland1
Copy link

Works for me..

@uBlock-user uBlock-user added the unable to reproduce cannot reproduce the issue label Apr 27, 2021
@uBlock-user
Copy link
Contributor

Is cosmetic filtering disabled for booking.com? If so, enable it.

@thany
Copy link
Author

thany commented Apr 28, 2021

Oh is that it... I see.

Initially after enabling it it still didn't work, but after a secondary reload it started working.

So that makes the bug slightly different:

If cosmetic filtering is off, element picker mode is not working. Instead, nothing happens and no message is displayed telling the user to turn on cosmetic filtering first. It is also not turned on automatically. To a user, it feels like element picker mode is broken.

@uBlock-user
Copy link
Contributor

Duplicate of gorhill/uBlock#3212

@uBlock-user uBlock-user marked this as a duplicate of gorhill/uBlock#3212 Apr 28, 2021
@uBlock-user uBlock-user added duplicate This issue or pull request already exists and removed unable to reproduce cannot reproduce the issue labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants