Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiegel.de: element pickup and cosmetic filters are disabled when using current build-in 'ublock filters' #7312

Closed
LonelyHellhound opened this issue May 4, 2020 · 7 comments

Comments

@LonelyHellhound
Copy link

LonelyHellhound commented May 4, 2020

URL(s) where the issue occurs

https://www.spiegel.de

Describe the issue

The current 'ublock filters' contains a rule for spiegel.de that disabled all cosmetic filters and the possiblity to pickup an element.
This issue occurs only on spiegel.de.

Versions

  • Browser/version: tested with Firefox 76, Edge, Vivaldi 3.0
  • uBlock Origin version: 1.26.2

Settings

Notes

The rule that causes the issue can be found in line 4920:

@@||spiegel.de^$shide

As soon as this rule was removed ublock works as expected.

@mapx-
Copy link
Contributor

mapx- commented May 4, 2020

Without that filter you'll get anti adblocking stuff

@LonelyHellhound
Copy link
Author

But if this filter is enabled, cosmetic filters and the pickup functionality are completely disabled :-|

For example I hide the complete header (via the pickup feature)

If rule @@||spiegel.de^$shide is disabled:
Screenshot at 2020-05-04 17-40-45

If rule @@||spiegel.de^$shide is enabled:
Screenshot at 2020-05-04 17-38-56

@uBlock-user
Copy link
Contributor

uBlock-user commented May 4, 2020

But if this filter is enabled, cosmetic filters and the pickup functionality are completely disabled

Yes, it's a uBO bug, hasn't been fixed yet.

@mapx-
Copy link
Contributor

mapx- commented May 4, 2020

Hmm, cannot be fixed (in this case), shide will disable any filter created by the picker

@okiehsch
Copy link
Contributor

okiehsch commented May 5, 2020

You can add

||spiegel.de^$shide,important
spiegel.de#@#.asset-affiliatebox
spiegel.de#@#.nativead
spiegel.de#@#.nativead + .headline-date
spiegel.de#@#a[href^="http://paid.outbrain.com/network/redir?"]
spiegel.de#@#a[href^="https://paid.outbrain.com/network/redir?"]
spiegel.de#@#a[data-nvp*="'trafficUrl':'https://paid.outbrain.com/network/redir?"]
spiegel.de#@#a[onmousedown^="this.href='https://paid.outbrain.com/network/redir?"]
spiegel.de#@#a[onmousedown^="this.href='http://paid.outbrain.com/network/redir?"]

to your filter list. The picker will work and you should not see any anti adblock message.

@RolfWojtech
Copy link

Just wanted to confirm that the solution by okiehsch works for me. Is there a reason why the filter list cannot be adjusted to reflect these changes?

mapx- added a commit that referenced this issue May 8, 2020
@mapx-
Copy link
Contributor

mapx- commented May 8, 2020

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants